Skip to content

DataViews: minimize padding for primary action buttons #75721

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
oandregal merged 3 commits into from
Feb 25, 2026
Merged

DataViews: minimize padding for primary action buttons #75721

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
298a152
Tweak padding for primary action buttons
oandregal Feb 19, 2026
8ed539f
Add changelog
oandregal Feb 23, 2026
02353ce
Add comment
oandregal Feb 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/dataviews/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
### Enhancements

- DataViews: Adjust column spacing in table layout when no titleField is provided. [#75410](https://github.com/WordPress/gutenberg/pull/75410)
- DataViews: minimize padding for primary actions. [#75721](https://github.com/WordPress/gutenberg/pull/75721)

## 12.0.0 (2026-02-18)

Expand Down
7 changes: 7 additions & 0 deletions packages/dataviews/src/components/dataviews-item-actions/style.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,10 @@
.dataviews-action-modal {
z-index: z-index(".dataviews-action-modal");
}

// TODO: the way forward here would be to use the new unstyle button coming
// from wordpress/ui package, but we're not ready to use it yet.
// See https://github.com/WordPress/gutenberg/pull/75721/
.dataviews-item-actions .components-button:not(.dataviews-all-actions-button) {

@ntsekouras ntsekouras Feb 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we go with this approach we should probably move these styles to the table layout styles, right?

@oandregal oandregal Feb 19, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These styles are only affecting the following state: when the consumer uses the <ItemActions> component to render both the all actions button + the primary actions left to it. In all those cases we'd want this padding. It just happens that the only that uses this config is the table one.

  • table: <ItemAction /> (renders primary actions)
  • grid: <ItemActions isCompact /> (does not render primary actions)
  • activity: <ItemActions isCompact /> (does not render primary actions). This layout renders primary actions separately that are unaffected by this change.
  • list: renders actions on its own, to control keyboard interactions.

padding: 0 $grid-unit-05;
}
Loading