Skip to content

Fix flaky Quick Edit e2e test #75714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Mamaduka merged 2 commits into from
Feb 19, 2026
Merged

Fix flaky Quick Edit e2e test #75714

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e9c26c
Fix flaky Quick Edit e2e test
Mamaduka Feb 19, 2026
b5f2c2f
Fix more locators
Mamaduka Feb 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions test/e2e/specs/site-editor/page-list.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@

await page
.getByRole( 'option', { name: 'Sample Page' } )
Comment thread
Mamaduka marked this conversation as resolved.
Resolved
.click();

Check failure on line 280 in test/e2e/specs/site-editor/page-list.spec.js

View workflow job for this annotation

GitHub Actions / Playwright - 6

[chromium] › test/e2e/specs/site-editor/page-list.spec.js:379:5 › Page List › Quick Edit Mode › should initialize 

  1) [chromium] › test/e2e/specs/site-editor/page-list.spec.js:379:5 › Page List › Quick Edit Mode › should initialize, edit, and update parent field correctly 
    Error: locator.click: Error: strict mode violation: getByRole('option', { name: 'Sample Page' }) resolved to 2 elements:
        1) <li role="option" aria-selected="true" id="components-form-token-suggestions-combobox-control-0-0" class="components-form-token-field__suggestion is-selected">…</li> aka locator('#components-form-token-suggestions-combobox-control-0-0')
        2) <li role="option" aria-selected="false" class="components-form-token-field__suggestion" id="components-form-token-suggestions-combobox-control-0-1">…</li> aka locator('#components-form-token-suggestions-combobox-control-0-1')

    Call log:
      - waiting for getByRole('option', { name: 'Sample Page' })


      278 | 					await page
      279 | 						.getByRole( 'option', { name: 'Sample Page' } )
    > 280 | 						.click();
          | 						 ^
      281 | 				},
      282 | 				assertEditedState: async ( page ) => {
      283 | 					const parent = page
        at performEdit (/home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/page-list.spec.js:280:8)
        at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/page-list.spec.js:383:6
},
assertEditedState: async ( page ) => {
const parent = page
Expand Down Expand Up @@ -357,10 +357,15 @@
await page.getByRole( 'button', { name: 'Layout' } ).click();
await page.getByRole( 'menuitemradio', { name: 'Table' } ).click();

// Trigger Quick Edit action on Privacy Policy row
// Trigger Quick Edit action on Privacy Policy row.
const row = page
.getByRole( 'row', { name: /Privacy Policy/ } )
.first();
.getByRole( 'row', {
name: /Privacy Policy/,
} )
.filter( {
// Targets newly created pages which are published by default.
has: page.getByRole( 'cell', { name: 'Published' } ),
} );
await row.getByRole( 'button', { name: 'Quick Edit' } ).click();
} );

Expand Down
Loading