Skip to content

Real-time collaboration: Fix style mounting in RTC overlay #75700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alecgeatches merged 1 commit into from
Feb 26, 2026
Merged

Real-time collaboration: Fix style mounting in RTC overlay #75700

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions packages/editor/src/components/collaborators-overlay/overlay.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,3 @@
// @ts-expect-error No exported types
import { useStyleOverride } from '@wordpress/block-editor';
import { privateApis as componentsPrivateApis } from '@wordpress/components';
import { useResizeObserver, useMergeRefs } from '@wordpress/compose';
import { useEffect, useState } from '@wordpress/element';
Expand Down Expand Up @@ -221,11 +219,6 @@ export function Overlay( {
postId,
postType,
}: OverlayProps ) {
useStyleOverride( {
id: 'collaborators-overlay',
css: COLLABORATORS_OVERLAY_STYLES,
} );

// Use state for the overlay element so that the hook re-runs once the ref is attached.
const [ overlayElement, setOverlayElement ] =
useState< HTMLDivElement | null >( null );
Expand Down Expand Up @@ -258,6 +251,7 @@ export function Overlay( {
// scrollable elements like cursor indicators.
return (
<div className="collaborators-overlay-full" ref={ mergedRef }>
<style>{ COLLABORATORS_OVERLAY_STYLES }</style>
{ cursors.map( ( cursor ) => (
<div
key={ cursor.clientId }
Expand Down
Loading