Skip to content

Fix: Hide link controls in sidebar when submenus open on click #75637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
scruffian merged 8 commits into from
Feb 18, 2026
Merged

Fix: Hide link controls in sidebar when submenus open on click #75637

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
67b3a6d
Initial plan
Copilot Feb 17, 2026
138de82
Hide Link to control in sidebar when submenus open on click
Copilot Feb 17, 2026
3e0ee02
Add tests for openSubmenusOnClick prop in Controls component
Copilot Feb 17, 2026
5e0f6de
Fix JSDoc alignment in controls.js
Copilot Feb 17, 2026
1577e07
Rename prop from openSubmenusOnClick to isLinkEditable
Copilot Feb 17, 2026
ab4e301
Nest Edit/View buttons inside isLinkEditable conditional
Copilot Feb 17, 2026
f470132
Remove tests for isLinkEditable prop
Copilot Feb 17, 2026
9b4fd7e
Hide "Open in new tab" when links are not editable
Copilot Feb 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
198 changes: 105 additions & 93 deletions packages/block-library/src/navigation-link/shared/controls.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,12 +72,18 @@ function getEntityTypeName( type, kind ) {
* This component provides the inspector controls (ToolsPanel) that are identical
* between both navigation blocks.
*
* @param {Object} props - Component props
* @param {Object} props.attributes - Block attributes
* @param {Function} props.setAttributes - Function to update block attributes
* @param {string} props.clientId - Block client ID
* @param {Object} props - Component props
* @param {Object} props.attributes - Block attributes
* @param {Function} props.setAttributes - Function to update block attributes
* @param {string} props.clientId - Block client ID
* @param {boolean} props.isLinkEditable - Whether link editing should be allowed
*/
export function Controls( { attributes, setAttributes, clientId } ) {
export function Controls( {
attributes,
setAttributes,
clientId,
isLinkEditable = true,
} ) {
const { label, url, description, rel, opensInNewTab } = attributes;
const dropdownMenuProps = useToolsPanelDropdownMenuProps();

Expand Down Expand Up @@ -188,99 +194,105 @@ export function Controls( { attributes, setAttributes, clientId } ) {
/>
</ToolsPanelItem>

<ToolsPanelItem
hasValue={ () => !! url }
label={ __( 'Link to' ) }
onDeselect={ () =>
setAttributes( {
url: undefined,
id: undefined,
kind: undefined,
type: undefined,
} )
}
isShownByDefault
>
<LinkPicker
preview={ preview }
onSelect={ handleLinkChange }
suggestionsQuery={ getSuggestionsQuery(
attributes.type,
attributes.kind
) }
label={ __( 'Link to' ) }
help={ helpText ? helpText : undefined }
/>
</ToolsPanelItem>
{ isLinkEditable && (
Comment thread
jeryj marked this conversation as resolved.
<>
<ToolsPanelItem
hasValue={ () => !! url }
label={ __( 'Link to' ) }
onDeselect={ () =>
setAttributes( {
url: undefined,
id: undefined,
kind: undefined,
type: undefined,
} )
}
isShownByDefault
>
<LinkPicker
preview={ preview }
onSelect={ handleLinkChange }
suggestionsQuery={ getSuggestionsQuery(
attributes.type,
attributes.kind
) }
label={ __( 'Link to' ) }
help={ helpText ? helpText : undefined }
/>
</ToolsPanelItem>

{ url && (
<HStack
className="navigation-link-to__actions"
alignment="left"
justify="left"
style={ { gridColumn: '1 / -1' } }
>
{ hasUrlBinding &&
isBoundEntityAvailable &&
entityRecord?.id &&
attributes.kind === 'post-type' &&
onNavigateToEntityRecord && (
<Button
size="compact"
variant="secondary"
onClick={ () => {
onNavigateToEntityRecord( {
postId: entityRecord.id,
postType: attributes.type,
} );
} }
__next40pxDefaultSize
>
{ sprintf(
/* translators: %s: entity type (e.g., "page", "post", "category") */
__( 'Edit %s' ),
entityTypeName
) }
</Button>
) }
{ isViewableUrl && (
<Button
size="compact"
variant="secondary"
href={ viewUrl }
target="_blank"
icon={ external }
iconPosition="right"
__next40pxDefaultSize
{ url && (
<HStack
className="navigation-link-to__actions"
alignment="left"
justify="left"
style={ { gridColumn: '1 / -1' } }
>
{ sprintf(
/* translators: %s: entity type (e.g., "page", "post", "category") or "link" for external links */
__( 'View %s' ),
attributes.kind &&
attributes.type &&
attributes.kind !== 'custom'
? entityTypeName
: __( 'link' )
{ hasUrlBinding &&
isBoundEntityAvailable &&
entityRecord?.id &&
attributes.kind === 'post-type' &&
onNavigateToEntityRecord && (
<Button
size="compact"
variant="secondary"
onClick={ () => {
onNavigateToEntityRecord( {
postId: entityRecord.id,
postType: attributes.type,
} );
} }
__next40pxDefaultSize
>
{ sprintf(
/* translators: %s: entity type (e.g., "page", "post", "category") */
__( 'Edit %s' ),
entityTypeName
) }
</Button>
) }
{ isViewableUrl && (
<Button
size="compact"
variant="secondary"
href={ viewUrl }
target="_blank"
icon={ external }
iconPosition="right"
__next40pxDefaultSize
>
{ sprintf(
/* translators: %s: entity type (e.g., "page", "post", "category") or "link" for external links */
__( 'View %s' ),
attributes.kind &&
attributes.type &&
attributes.kind !== 'custom'
? entityTypeName
: __( 'link' )
) }
</Button>
) }
</Button>
</HStack>
) }
</HStack>
) }

<ToolsPanelItem
hasValue={ () => !! opensInNewTab }
label={ __( 'Open in new tab' ) }
onDeselect={ () => setAttributes( { opensInNewTab: false } ) }
isShownByDefault
>
<CheckboxControl
label={ __( 'Open in new tab' ) }
checked={ opensInNewTab }
onChange={ ( value ) =>
setAttributes( { opensInNewTab: value } )
}
/>
</ToolsPanelItem>
<ToolsPanelItem
hasValue={ () => !! opensInNewTab }
label={ __( 'Open in new tab' ) }
onDeselect={ () =>
setAttributes( { opensInNewTab: false } )
}
isShownByDefault
>
<CheckboxControl
label={ __( 'Open in new tab' ) }
checked={ opensInNewTab }
onChange={ ( value ) =>
setAttributes( { opensInNewTab: value } )
}
/>
</ToolsPanelItem>
</>
) }

<ToolsPanelItem
hasValue={ () => !! description }
Expand Down
1 change: 1 addition & 0 deletions packages/block-library/src/navigation-submenu/edit.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -340,6 +340,7 @@ export default function NavigationSubmenuEdit( {
attributes={ attributes }
setAttributes={ setAttributes }
clientId={ clientId }
isLinkEditable={ ! openSubmenusOnClick }
/>
</InspectorControls>
<div { ...blockProps }>
Expand Down
Loading