Skip to content

Use null coalescing operator ?? instead of isset() ternaries #75419

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Soean merged 1 commit into from
Feb 11, 2026
+13 −13
Merged

Use null coalescing operator ?? instead of isset() ternaries #75419

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-library/src/navigation-submenu/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,8 @@
* @return string The visibility mode: 'hover', 'click', or 'always'.
*/
function block_core_navigation_submenu_get_submenu_visibility( $attributes ) {
$submenu_visibility = isset( $attributes['submenuVisibility'] ) ? $attributes['submenuVisibility'] : null;
$open_submenus_on_click = isset( $attributes['openSubmenusOnClick'] ) ? $attributes['openSubmenusOnClick'] : null;
$submenu_visibility = $attributes['submenuVisibility'] ?? null;
$open_submenus_on_click = $attributes['openSubmenusOnClick'] ?? null;

// If new attribute is set, use it.
if ( null !== $submenu_visibility ) {
Expand Down
4 changes: 2 additions & 2 deletions packages/block-library/src/navigation/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@
* @return string The visibility mode: 'hover', 'click', or 'always'.
*/
function block_core_navigation_get_submenu_visibility( $attributes ) {
$submenu_visibility = isset( $attributes['submenuVisibility'] ) ? $attributes['submenuVisibility'] : null;
$open_submenus_on_click = isset( $attributes['openSubmenusOnClick'] ) ? $attributes['openSubmenusOnClick'] : null;
$submenu_visibility = $attributes['submenuVisibility'] ?? null;
$open_submenus_on_click = $attributes['openSubmenusOnClick'] ?? null;

// If new attribute is set, use it.
if ( null !== $submenu_visibility ) {
Expand Down
6 changes: 3 additions & 3 deletions packages/block-library/src/playlist-track/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,9 @@ function render_block_core_playlist_track( $attributes ) {

$wrapper_attributes = get_block_wrapper_attributes();

$unique_id = isset( $attributes['uniqueId'] ) ? $attributes['uniqueId'] : wp_unique_id( 'playlist-track-' );
$artist = isset( $attributes['artist'] ) ? $attributes['artist'] : '';
$length = isset( $attributes['length'] ) ? $attributes['length'] : '';
$unique_id = $attributes['uniqueId'] ?? wp_unique_id( 'playlist-track-' );
$artist = $attributes['artist'] ?? '';
$length = $attributes['length'] ?? '';
$title = isset( $attributes['title'] ) && ! empty( $attributes['title'] ) ? $attributes['title'] : __( 'Unknown title' );

$context = wp_interactivity_data_wp_context(
Expand Down
12 changes: 6 additions & 6 deletions packages/block-library/src/playlist/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,17 +35,17 @@ function render_block_core_playlist( $attributes, $content, $block ) {
$inner_block->context['playlistId'] = $playlist_id;

$track_attributes = $inner_block->attributes;
$unique_id = isset( $track_attributes['uniqueId'] ) ? $track_attributes['uniqueId'] : wp_unique_id( 'playlist-track-' );
$unique_id = $track_attributes['uniqueId'] ?? wp_unique_id( 'playlist-track-' );
$playlist_tracks[] = $unique_id;

$inner_block->attributes['uniqueId'] = $unique_id;

// Extract track metadata from block attributes.
$title = isset( $track_attributes['title'] ) && ! empty( $track_attributes['title'] ) ? $track_attributes['title'] : __( 'Unknown title' );
$artist = isset( $track_attributes['artist'] ) ? $track_attributes['artist'] : '';
$album = isset( $track_attributes['album'] ) ? $track_attributes['album'] : '';
$image = isset( $track_attributes['image'] ) ? $track_attributes['image'] : '';
$url = isset( $track_attributes['src'] ) ? $track_attributes['src'] : '';
$artist = $track_attributes['artist'] ?? '';
$album = $track_attributes['album'] ?? '';
$image = $track_attributes['image'] ?? '';
$url = $track_attributes['src'] ?? '';
$aria_label = $title;

if ( $title && $artist && $album ) {
Expand Down Expand Up @@ -100,7 +100,7 @@ function render_block_core_playlist( $attributes, $content, $block ) {
$html = '<div class="wp-block-playlist__current-item">';

// The alt attribute is intentionally left empty, as the image is decorative.
if ( isset( $attributes['showImages'] ) ? $attributes['showImages'] : false ) {
if ( $attributes['showImages'] ?? false ) {
$html .=
'<img
class="wp-block-playlist__item-image"
Expand Down
Loading