Repository navigation
wp-env: Fix mixed runtime detection issues - #75057
Merged
Merged
Conversation
youknowriad
requested review from
ObliviousHarmony and
t-hamano
as code owners
January 29, 2026 15:35
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
youknowriad
force-pushed
the
wp-env-runtime-fix
branch
from
January 29, 2026 15:38
6efb54e to
4a41890
Compare
|
Size Change: 0 B Total Size: 3 MB ℹ️ View Unchanged
|
youknowriad
force-pushed
the
wp-env-runtime-fix
branch
2 times, most recently
from
January 29, 2026 15:57
0d53e2c to
6f5409d
Compare
youknowriad
added
[Type] Bug
- Store runtime type in cache instead of using file-based detection - Add interactive prompt when switching runtimes (e.g., Docker to Playground) - detectRuntime() now throws EnvironmentNotInitializedError if environment not initialized - Commands (stop, destroy, clean, logs, run) properly handle uninitialized environments Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
youknowriad
force-pushed
the
wp-env-runtime-fix
branch
from
January 29, 2026 16:08
6f5409d to
9c6647e
Compare
mcsf
approved these changes
Jan 29, 2026
Comment on lines
+60
to
+63
| shouldDestroy = await confirm( { | ||
| message: `Environment was previously started with '${ savedRuntime }' runtime. Destroy it and start with '${ runtimeName }'?`, | ||
| default: true, | ||
| } ); |
Contributor
There was a problem hiding this comment.
This isn't a big dea because I don't really care about wp-env (I've long disliked its internals and it's already using plenty of IMO frivolous dependencies), but I'll just point out that this could be achieved with Node's own Readline interface:
const readline = require('node:readline/promises');
const rl = readline.createInterface({
input: process.stdin,
output: process.stdout,
terminal: true,
});
(async () => {
const answer = await rl.question('Do you want to continue? (y/n) ');
rl.close();
const ok = /^y(es)?$/i.test(answer.trim());
console.log(ok ? 'Confirmed' : 'Cancelled');
})();
Contributor
Author
There was a problem hiding this comment.
inquirer/prompts is not what I would call frivolous dependencies personally though. It's kind of standard when writing interactive JS tools.
Merged
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes issues with mixed runtime detection when switching between Docker and Playground runtimes.
Changes:
wp-env-cache.json) instead of file-based detectiondetectRuntime()now throwsEnvironmentNotInitializedErrorif environment not initializedcli.jsfor cleaner codeTest plan
Fresh start with Docker:
Switch runtime (interactive prompt):
Commands on uninitialized env:
Run existing tests:
🤖 Generated with Claude Code