Repository navigation
Add UploadSaveLockWrapper to manage save locks during uploads - #74712
Merged
adamsilverstein merged 3 commits intoJan 24, 2026
Conversation
adamsilverstein
added
[Feature] Client Side Media
adamsilverstein
marked this pull request as ready for review
January 17, 2026 00:22
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +5.77 kB (+0.19%) Total Size: 3.1 MB
ℹ️ View Unchanged
|
…ploads Wraps the block editor children with UploadSaveLockWrapper component that uses the useUploadSaveLock hook to properly manage post save locks based on upload state. This ensures the save button state correctly reflects ongoing media uploads. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add the useUploadSaveLock hook that manages post save and autosave locks based on upload state. The hook monitors the upload-media store and locks post saving when uploads are in progress, preventing users from publishing or saving while files are still uploading. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Remove direct import from @wordpress/editor to prevent circular dependency between block-editor and editor packages. Instead, dynamically check if the editor store is registered and access it through the registry. This ensures the hook works safely in contexts where the editor store may not be available (e.g., standalone block editor widgets). Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
adamsilverstein
force-pushed
the
74554-save-button-remains-disabled-with-use-upload-save-lock
branch
from
January 24, 2026 17:28
008673e to
3fedb65
Compare
adamsilverstein
requested review from
ajitbohra,
nerrad,
ntwb and
spacedmonkey
as code owners
January 24, 2026 17:28
adamsilverstein
changed the base branch from
trunk
to
feature/client-side-media-dev
January 24, 2026 17:28
adamsilverstein
merged commit Jan 24, 2026
3fedb65
into
feature/client-side-media-dev
39 of 40 checks passed
adamsilverstein
deleted the
74554-save-button-remains-disabled-with-use-upload-save-lock
branch
January 24, 2026 17:31
adamsilverstein
restored the
74554-save-button-remains-disabled-with-use-upload-save-lock
branch
January 26, 2026 18:08
adamsilverstein
deleted the
74554-save-button-remains-disabled-with-use-upload-save-lock
branch
January 26, 2026 18:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Closes #74554
Adds an
UploadSaveLockWrappercomponent to the block editor provider that uses theuseUploadSaveLockhook to properly manage post save locks based on upload state.Why?
When the Client Side Media Processing experiment is enabled, the save button stays disabled after batch uploads complete. This happens because the save lock isn't being properly released when uploads finish.
As noted in #74501, after dragging and dropping images to upload onto an image or gallery block, the save/publish button remains unavailable even after all uploads conclude.
How?
This PR introduces an
UploadSaveLockWrappercomponent that:__experimentalMediaProcessingflag is enableduseUploadSaveLockhook to track upload state from theupload-mediastoreMediaUploadProviderto access the upload-media storeTesting Instructions
Testing Instructions for Keyboard