Skip to content

E2E utils: remove ts-expect-error for web-vitals - #74405

Closed
jsnajdr wants to merge 1 commit into
trunkfrom
remove/web-vitals-ts-error
Closed

jsnajdr wants to merge 1 commit into
trunkfrom
remove/web-vitals-ts-error

Conversation

@jsnajdr

@jsnajdr jsnajdr commented Jan 7, 2026

Copy link
Copy Markdown
Member

Fixing something I notices when working on #74348: the ts-expect-error directive when importing web-vitals is no longer necessary. At least locally. In CI I noticed that the error still happens. So here I'm doing an isolated experiment to figure this out.

@jsnajdr
jsnajdr requested a review from swissspidy January 7, 2026 08:34
@jsnajdr jsnajdr self-assigned this Jan 7, 2026
@jsnajdr
jsnajdr requested a review from kevin940726 as a code owner January 7, 2026 08:34
@jsnajdr jsnajdr added the [Type] Code Quality Issues or PRs that relate to code quality label Jan 7, 2026
@github-actions github-actions Bot added the [Package] E2E Tests /packages/e2e-tests label Jan 7, 2026
@jsnajdr

jsnajdr commented Jan 7, 2026

Copy link
Copy Markdown
Member Author

Very interesting. In CI this patch fails completely, but locally I have exactly the opposite error 🤔

@github-actions

github-actions Bot commented Jan 7, 2026 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: jsnajdr <jsnajdr@git.wordpress.org>
Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka

Copy link
Copy Markdown
Member

Let's base and resolve conflicts. Checks might pass on CI now.

@youknowriad

Copy link
Copy Markdown
Contributor

Should we close or ship this PR?

@jsnajdr

jsnajdr commented Sep 4, 2026

Copy link
Copy Markdown
Member Author

Let's close this, it was an exploratory PR and the error is still there. Trying to actually fix it leads to a sort of rabbit hole.

@jsnajdr jsnajdr closed this Sep 4, 2026
@youknowriad
youknowriad deleted the remove/web-vitals-ts-error branch September 4, 2026 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Package] E2E Tests /packages/e2e-tests [Type] Code Quality Issues or PRs that relate to code quality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants