Repository navigation
Conversation
|
Very interesting. In CI this patch fails completely, but locally I have exactly the opposite error 🤔 |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Let's base and resolve conflicts. Checks might pass on CI now. |
|
Should we close or ship this PR? |
|
Let's close this, it was an exploratory PR and the error is still there. Trying to actually fix it leads to a sort of rabbit hole. |
Fixing something I notices when working on #74348: the
ts-expect-errordirective when importingweb-vitalsis no longer necessary. At least locally. In CI I noticed that the error still happens. So here I'm doing an isolated experiment to figure this out.