[youknowriad]

Related #72032
Related WordPress/wordpress-develop#10638

What?

Use get_current_screen() for generic page detection in wp-admin pages
This PR updates the page-wp-admin.php template to check both $_GET['page'] and get_current_screen()->id for page detection. This allows the same code to work in both Gutenberg plugin context (menu page access) and WordPress Core context (direct file access) without requiring transformations.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: youknowriad <youknowriad@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[jsnajdr]

@youknowriad The e2e failure on this PR was not random, fixing in 44cc468

[youknowriad]

Yes, but I don't believe it's related to this PR.

[jsnajdr]

Yes, but I don't believe it's related to this PR.

It is. Checkout this PR's commit in trunk, the preload.spec.php test fails. Checkout the previous commit, it succeeds. Very reliable.

[youknowriad]

Very weird :) Sorry about that.

[jsnajdr]

No worries, it's now fixed in trunk after #73822 got merged 🙂 Although there is probably one more failing e2e test, template-id-format.spec.js. But here I don't know which PR caused it.