Skip to content

Site editor global styles settings: preserve non-global styles in default site editor settings #74088

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ramonjd merged 2 commits into from
Dec 18, 2025
Merged

Site editor global styles settings: preserve non-global styles in default site editor settings #74088

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9d11def
Preserve non-global styles in default editor settings
ramonjd Dec 18, 2025
98b9394
Remove defaultEditorStyles from settings
ramonjd Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/edit-site/src/components/block-editor/use-site-editor-settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,15 @@ export function useSpecificEditorSettings() {
}, [ mergedConfig ] );

const defaultEditorSettings = useMemo( () => {
// Preserve non-global styles from settings.styles (e.g., editor styles from add_editor_style)
const nonGlobalStyles = ( settings?.styles ?? [] ).filter(

@ramonjd ramonjd Dec 18, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note there are some concerns with the current architecture.

This PR only proposes to get things working for users while those concerns are addressed. They appear to require non-trivial refactors.

See: #73952 (comment)

@ramonjd ramonjd Dec 18, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe I should add some comments to explain why we've had to do all this, including the bug fix in #73952

( style ) => ! style.isGlobalStyles
);

return {
...settings,
styles: [
...nonGlobalStyles,
...globalStyles,
{
// Forming a "block formatting context" to prevent margin collapsing.
Expand Down
Loading