Repository navigation
Conversation
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
| </GlobalStylesNavigationScreen> | ||
| ) ) } | ||
|
|
||
| <ContextScreens /> |
There was a problem hiding this comment.
Removing this component is the actual fix.
| <Fragment key={ block.name }> | ||
| <GlobalStylesNavigationScreen | ||
| path={ | ||
| '/blocks/' + | ||
| encodeURIComponent( block.name ) | ||
| } | ||
| > | ||
| <ScreenBlock name={ block.name } /> | ||
| </GlobalStylesNavigationScreen> | ||
| <ContextScreens | ||
| name={ block.name } | ||
| parentMenu={ | ||
| '/blocks/' + | ||
| encodeURIComponent( block.name ) | ||
| } | ||
| /> | ||
| </Fragment> |
There was a problem hiding this comment.
A slight code quality improvement.
|
How does one access these screens from UI? I get it working via URL, but can find navigation button in UI 😅 Example URL: gutenberg/packages/global-styles-ui/src/global-styles-ui.tsx Lines 89 to 93 in 98b5c5c |
t-hamano
left a comment
t-hamano
left a comment
There was a problem hiding this comment.
Thanks for the PR! Actually, I was also trying to fix it in #73279 😄
How does one access these screens from UI? I get it working via URL, but can find navigation button in UI 😅
Example URL:
wp-admin/site-editor.php?p=%2Fstyles§ion=%2Fblocks%2Fcore%252Fheading%2Fcolors%2Fpalette
I think Block-level color palettes aren't supported yet, but they may have been unintentionally exposed here. I think it would be better to remove this navigation screen altogether.
|
Sorry, I missed that PR. Let's continue working on the fix there. I'm going to close this. |
2 participants
What?
This is a follow-up to #72599.
PR removes duplicate rendering of the general colors palette screen, which fixes the Navigator component warning. The screen is already rendered above.
gutenberg/packages/global-styles-ui/src/global-styles-ui.tsx
Lines 198 to 200 in 7b61690
Testing Instructions
Testing Instructions for Keyboard
Same.
Screenshots or screencast