Repository navigation
Conversation
|
Flaky tests detected in 95c87ef. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/27605304690
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
3d624fb to
558893d
Compare
|
Thanks for the PR! I thought we had tried that before when investigating and the CI didn't pass. Wasn't that the case?
The difference between now and back then is that the previous failures were from |
Thank you for noticing that! Indeed, the test method was unavailable in the previous version and we see an error:
This change would be good to make but unfortunately we'll have to wait 🙂 |
98ddfe2 to
8072dec
Compare
|
|
8072dec to
95c87ef
Compare
What?
Follow-up to #72236.
Updates background block support PHP tests to compare generated wrapper markup with
assertEqualHTML()instead of byte-for-byte string equality. Also enables the PHP unit test workflow to run against the previous major WordPress version on PRs.Why?
Equivalent HTML can serialize with different character references across WordPress versions, for example
'vs'. These differences should not fail tests when the resulting HTML is semantically equivalent.How?
assertEquals()withassertEqualHTML()for HTML semantic equality comparison instead of string equality.Testing Instructions
CI workflow should be sufficient. This is a testing change.
Use of AI Tools
OpenAI Codex was used to help rebase the branch, resolve conflicts, run local checks, and draft this PR description. The original changes were authored without the use of AI.