Repository navigation
Testing: Remove e2e-test-utils package and deprecated test configuration - #72880
Merged
Merged
Conversation
aduth
requested review from
ajitbohra,
desrosj,
fabiankaegy,
juanmaguitar,
nerrad and
ntwb
as code owners
October 31, 2025 14:16
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
aduth
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 2.45 MB ℹ️ View Unchanged
|
Member
Author
I decided to lump in this change with 35abb82 because it looks like the dependency isn't actually used in |
Member
|
Thanks for working on this, @aduth! Love all the red in this PR. How would this affect projects using this legacy utils package? I'm guessing they'll still be able to use the last published version. Is that correct? |
Member
Author
Good question! The packages that are already published would be unaffected, so someone currently using it will be able to continue using it. The change here is that we'd no longer maintain or publish new versions, although even that is something we could change our mind and revisit in the future (less likely for this package, but moreso as a general practice for deprecating packages). One possible action item we might consider is formally deprecating the package, so that someone installing the package would see a notice in their terminal. I'm not sure we need to be quite so "in your face" about it if the package is working fine for someone though. |
manzoorwanijk
approved these changes
Nov 4, 2025
manzoorwanijk
left a comment
manzoorwanijk
left a comment
Member
There was a problem hiding this comment.
There is no better feeling than removing code when it's no longer needed 😄
Member
|
Yes, we can mark the npm package as deprepacted but it will still be downloadable. |
aduth
force-pushed
the
remove/deprecated-test-packages
branch
from
November 4, 2025 15:53
35abb82 to
50a770a
Compare
|
Flaky tests detected in 8307262. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/19079413457
|
aduth
force-pushed
the
remove/deprecated-test-packages
branch
from
November 4, 2025 17:59
50a770a to
e5cef0b
Compare
Contributor
|
Are we deprecating the package officially in npm? |
Member
Author
I think we can, maybe with a message like "This package has been deprecated in favor of Unless someone objects, I'll do this tomorrow. |
Contributor
|
Isn't there a command in npm that does this automatically? |
Member
Author
|
I'm not sure what you mean by "automatically", but the |
Member
Author
|
Apparently I had myself removed or was otherwise removed from the NPM organization. Someone with permissions want to run the command instead? |
Contributor
|
I got this any idea |
Member
Author
|
Huh, that was the same error I got, but I figured it was because I wasn't an owner according to |
Contributor
|
@aduth It looks like I was not logged in properly in the console. It did work now. Thanks Andrew for the pointers. |
Member
Author
|
Nice! I see the banner now too on the NPM overview page: 
|
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Related to #38851
Removes all package code and documentation references related to the legacy end-to-end test setup:
packages/e2e-test-utilspackages/e2e-testsaside from plugins still referenced in current end-to-end testsWhy?
form-datawith a critical security vulnerability, though the actual risk is pretty low. This dependency will be fully removed in a separate pull request.Testing Instructions
Verify that end-to-end tests still pass.