Repository navigation
Template activation: skip gutenberg_get_registered_block_templates query when no slugs are left to find - #72795
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
ellatrix
added
[Type] Bug
Aljullu
left a comment
Aljullu
left a comment
There was a problem hiding this comment.
LGTM, confirming the warnings from Gutenberg are gone.
I can still see the warnings from WordPress (I'm on 6.9 beta 2), though. Is that expected? I guess this PR needs to be backported?
kmanijak
left a comment
kmanijak
left a comment
There was a problem hiding this comment.
Nice one! Tested with WP 6.8 + GB and warnings are gone!
With WP 6.9 beta 2 + GB they're still there (half less) but I assume it's because how compat works and both versions of activation (from beta and compat) run, right?
|
Yes, we will need to backport the PHP changes |
…ery when no slugs are left to find
2902e42 to
772ba3b
Compare
|
Thank you all! |
…ery when no slugs are left to find (#72795) Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Aljullu <aljullu@git.wordpress.org> Co-authored-by: kmanijak <karolmanijak@git.wordpress.org> Co-authored-by: bacoords <bacoords@git.wordpress.org>
github-actions
Bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.9 branch to get it included in the next release: ad996fb |
…ery when no slugs are left to find (#72795) Co-authored-by: ellatrix <ellatrix@git.wordpress.org> Co-authored-by: Aljullu <aljullu@git.wordpress.org> Co-authored-by: kmanijak <karolmanijak@git.wordpress.org> Co-authored-by: bacoords <bacoords@git.wordpress.org>
|
I just cherry-picked this PR to the release/22.0 branch to get it included in the next release: 9704c13 |
cbravobernal
removed
the
Backport to Gutenberg RC
4 participants
What?
Closes #72786. Cc @bacoords.
When no slugs are left to find (because they were all found in the database), skip the registered templates query instead of calling it with
slug__inset to an empty array. This could confuse plugins in thinking they need to return all registered templates.Why?
Prevents the function that gets registered templates from returning all registered templates. If it returns templates that have slugs that were not requested, there will be PHP warnings.
How?
Check
$remaining_slugs.Testing Instructions
Install Woo. Create a front-page template in the site editor and set it active. The front page should have no PHP warnings.
Testing Instructions for Keyboard
Screenshots or screencast