Skip to content

Template activation: disallow editing/trashing of non-database templates #72790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 2 commits into from
Oct 30, 2025
Merged

Template activation: disallow editing/trashing of non-database templates #72790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dcd9841
Template activation: non-database templates cannot be trashed/edited
ellatrix Oct 29, 2025
0af4fd3
Add comment
ellatrix Oct 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions packages/fields/src/actions/rename-post.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,12 @@ const renamePost: Action< PostWithPermissions > = {
if ( post.status === 'trash' ) {
return false;
}

// Non-database template cannot be edited.
if ( post.type === 'wp_template' && typeof post.id === 'string' ) {
return false;
}

// Templates, template parts and patterns have special checks for renaming.
if (
! [
Expand Down
5 changes: 5 additions & 0 deletions packages/fields/src/actions/trash-post.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ const trashPost: Action< PostWithPermissions > = {
return false;
}

// Non-database template cannot be trashed.
if ( item.type === 'wp_template' && typeof item.id === 'string' ) {
return false;
}

return (
!! item.status &&
! [ 'auto-draft', 'trash' ].includes( item.status ) &&
Expand Down