Repository navigation
Env: Remove non-functional WP_ENV_MULTISITE config - #72567
Merged
Merged
Conversation
t-hamano
added
[Type] Bug
t-hamano
force-pushed
the
env/multisite-override
branch
from
October 22, 2025 10:08
e2f4cd6 to
99bec1b
Compare
t-hamano
marked this pull request as ready for review
October 22, 2025 10:10
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 3 MB ℹ️ View Unchanged
|
t-hamano
force-pushed
the
env/multisite-override
branch
from
November 12, 2025 10:56
99bec1b to
c21eb28
Compare
t-hamano
force-pushed
the
env/multisite-override
branch
from
February 2, 2026 07:08
c21eb28 to
5510117
Compare
|
Flaky tests detected in 5510117. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/21580668217
|
Contributor
|
Maybe this variable is not needed anymore if we offer #75087 |
Contributor
Author
|
I understand your concern, but this PR fixes a feature that is documented but doesn't actually work: gutenberg/packages/env/README.md Lines 786 to 788 in 4d8d180 Another option is to remove any mention of the non-working |
Contributor
|
So that PR has been merged a year ago, and it's not working since then right? This makes me think that it might not be worth keeping this feature/variable around. WDYT? |
t-hamano
changed the title
WP_ENV_MULTISITE environment variable override not working correctlyWP_ENV_MULTISITE config
Contributor
Author
Yes 😅 Let's remove this config. |
youknowriad
approved these changes
Feb 4, 2026
MaggieCabrera
pushed a commit
that referenced
this pull request
Feb 10, 2026
* Env: Fix `WP_ENV_MULTISITE` environment variable override not working correctly * Remove non-functional WP_ENV_MULTISITE config Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up #68792
What?
I noticed that the
WP_ENV_MULTISITEenvironment variable override not working correctly.Why?
The necessary code was missing from the
getEnvironmentVarOverridesfunction.How?
Multisite is enabled when set to1ortrue, as follows:WP_ENV_MULTISITE=1 npm run wp-env startWP_ENV_MULTISITE="1" npm run wp-env startWP_ENV_MULTISITE=true npm run wp-env startWP_ENV_MULTISITE="true" npm run wp-env startAfter a discussion, we decided to remove the non-functional
WP_ENV_MULTISITEconfig. Themultisitefield inwp-env.jsonworks as before.Testing Instructions
Run either of the above commands, and confirm that the multisite environment is launched.Confirm that the
multisitefield inwp-env.jsonworks as before:{ "multisite": true }