Skip to content

Template activation: duplicate action should be available outside GB #72513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 5 commits into from
Oct 21, 2025
Merged

Template activation: duplicate action should be available outside GB #72513

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
3611498
Template activation: duplicate action should be available outside GB
ellatrix Oct 21, 2025
4934871
flip back
ellatrix Oct 21, 2025
0f64b8b
Adjust condition
ellatrix Oct 21, 2025
5e11fd6
Exception only for wp_template
ellatrix Oct 21, 2025
2e2b758
Flip
ellatrix Oct 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions packages/editor/src/dataviews/store/private-actions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -133,19 +133,28 @@ export const registerPostTypeSchema =
.resolveSelect( coreStore )
.getCurrentTheme();

let canDuplicate =
! [ 'wp_block', 'wp_template_part' ].includes(
postTypeConfig.slug
) &&
canCreate &&
duplicatePost;

// @ts-ignore
if ( ! globalThis.IS_GUTENBERG_PLUGIN ) {
// Outside Gutenberg, disable duplication except for wp_template.
if ( 'wp_template' !== postTypeConfig.slug ) {
canDuplicate = undefined;
}
}

const actions = [
postTypeConfig.viewable ? viewPost : undefined,
!! postTypeConfig.supports?.revisions
? viewPostRevisions
: undefined,
// @ts-ignore
globalThis.IS_GUTENBERG_PLUGIN
? ! [ 'wp_block', 'wp_template_part' ].includes(
postTypeConfig.slug
) &&
canCreate &&
duplicatePost
: undefined,
canDuplicate,

@oandregal oandregal Oct 21, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn't this make the duplicate action available for any post type (but wp_block, wp_template_part, page) in WordPress?

Note these actions are also used in the inspector of the post editor:

Screenshot 2025-10-21 at 11 28 52

We could enabling it just for templates, regardless of environment (gutenberg/wordpress).

@jorgefilipecosta jorgefilipecosta Oct 21, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @oandregal, it is making it available for posts too on the inspector. cc: @ellatrix

@ellatrix ellatrix Oct 21, 2025

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't know this affects the post editor

postTypeConfig.slug === 'wp_template_part' &&
canCreate &&
currentTheme?.is_block_theme
Expand Down
Loading