Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the Core Data Module to the reusable packages #7222

Merged
merged 3 commits into from
Jun 8, 2018
Merged

Move the Core Data Module to the reusable packages #7222

merged 3 commits into from
Jun 8, 2018

Conversation

youknowriad
Copy link
Contributor

Moving this package is straightforward, no real complications here :)

Testing instructions

  • Gutenberg loads as expected.

@youknowriad youknowriad requested a review from gziolo June 8, 2018 08:57
@gziolo
Copy link
Member

gziolo commented Jun 8, 2018

README file should contain some details how to install package from npm.

We usually update Jest config altogether with moving it to packages in here: https://github.com/WordPress/gutenberg/blob/master/test/unit/jest.config.json#L4-L9. I'm wondering why it didn't break any tests. It is very likely that @wordpress/core-data is never imported for tests.

gziolo
gziolo requested changes Jun 8, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two small things to fix and we should be good to go.

@gziolo gziolo added the npm Packages Related to npm packages label Jun 8, 2018
@gziolo gziolo added this to the 3.1 milestone Jun 8, 2018
gziolo
gziolo approved these changes Jun 8, 2018
View reviewed changes
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, we have another one ready to publish 💯

@Shelob9 Shelob9 mentioned this pull request Jun 8, 2018
Closed
19 tasks
@youknowriad youknowriad merged commit a9fab4d into master Jun 8, 2018
@youknowriad youknowriad deleted the add/core-data-package branch June 8, 2018 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gziolo gziolo gziolo approved these changes

Assignees
No one assigned
Labels
npm Packages Related to npm packages
Projects
None yet
Milestone
3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@youknowriad @gziolo