Fix regression with formatting toolbar #7167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The right-border on the alignments was missing. This PR changes how we paint separators, so it gets fixed. Verify this paints the right grouping borders for toolbar sections, both on mobile and desktop breakpoints, and with both the top-fixed toolbar and the block-fixed toolbar.
tofumatt
approved these changes
Jun 6, 2018
There was a problem hiding this comment.
What's the before scenario for this? Without an issue filed that this fixes or before screenshots it's hard to tell what this actually fixes… but the screenshots here look alright so I'll say okay.
But in the future if there's no issue, before screenshots would be grand 😁
|
Thanks for the review, and good thoughts. Here's what's in master:
Note the missing separator between alignments and inline. CC: @mcsf in case you would like to merge this. |
|
I think this should be added to the 3.1 milestone? |
|
Good catch, Zeb. It might actually go in a 3.0.2 milestone, but milestoning it 3.1 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The right-border on the alignments was missing. This PR changes how we paint separators, so it gets fixed.
Verify this paints the right grouping borders for toolbar sections, both on mobile and desktop breakpoints, and with both the top-fixed toolbar and the block-fixed toolbar.