Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Further explanation for why .normalize() is optional #7105

Merged
merged 1 commit into from
Jun 4, 2018

Conversation

tofumatt
Copy link
Member

@tofumatt tofumatt commented Jun 3, 2018

Re: #6983 (comment)

Just a brief documentation tweak.

Copy link
Member

@noisysocks noisysocks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for going into detail!

@noisysocks noisysocks merged commit 6a7085b into master Jun 4, 2018
@noisysocks noisysocks deleted the docs/normalize-in-ie branch June 4, 2018 06:47
@ellatrix
Copy link
Member

Thanks!

@Zodiac1978
Copy link

This is unsupported in IE 11 but it's a nice-to-have feature, not mandatory.
Not normalizing the content will only affect older browsers
entirely break the app.

@tofumatt I respectfully disagree.

Pasting NFD text will break the internal search in WP and can break the search on the website (like in Firefox), spellcheck, and the display (showing the character + combining character side by side and not overlaying it, Firefox is failing here for example).

And it can happen all the time that apps output NFD text and not NFC, like the W3C is recommending.

Not sure if I would call fixing this breakage "not mandatory".

@noisysocks
Copy link
Member

@Zodiac1978: Could you please create a new issue with steps to reproduce the bug you've described? Doing this will give everyone a space to discuss the bug and possible solutions e.g. polyfilling .normalize().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants