Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade mousetrap to 1.6.2 #7103

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Upgrade mousetrap to 1.6.2 #7103

merged 1 commit into from
Jun 4, 2018

Conversation

pento
Copy link
Member

@pento pento commented Jun 3, 2018

As part of #6508, we found that the mousetrap library had an Apache 2.0 license, which is not compatible with GPL2.

The mousetrap author has kindly agreed to add the LLVM exception to the license, making it GPL2 compatible.

This is the only change in the mousetrap 1.6.2 release.

@pento pento added the [Type] Task Issues or PRs that have been broken down into an individual action to take label Jun 3, 2018
@pento pento added this to the 3.0 milestone Jun 3, 2018
@pento pento self-assigned this Jun 3, 2018
@pento pento requested a review from a team June 3, 2018 05:40
Copy link
Member

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not a lawyer, but looks good to me 😆

@pento
Copy link
Member Author

pento commented Jun 4, 2018

Real lawyers wrote the language, so I'm not going to second guess them. 🙂

@pento pento merged commit b8c1f6d into master Jun 4, 2018
@pento pento deleted the fix/upgrade-mousetrap branch June 4, 2018 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants