Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build Tooling: Avoid using spread for objects to work with all node 8x versions #7043

Merged
merged 1 commit into from
May 31, 2018
Merged

Build Tooling: Avoid using spread for objects to work with all node 8x versions #7043

merged 1 commit into from
May 31, 2018

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented May 31, 2018

Description

Fixes issue raised by @jasmussen:

Could this PR have broken npm install for me? I'm getting this error:

screen shot 2018-05-31 at 09 51 15

How has this been tested?

npm install
npm run dev
npm run build

All of them should work on Node 8.2.x.

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@gziolo gziolo added [Type] Build Tooling Issues or PRs related to build tooling npm Packages Related to npm packages labels May 31, 2018
@gziolo gziolo added this to the 3.0 milestone May 31, 2018
@gziolo gziolo self-assigned this May 31, 2018
@gziolo gziolo requested a review from jasmussen May 31, 2018 08:37
@gziolo gziolo added the [Type] Bug An existing feature does not function as intended label May 31, 2018
jasmussen
jasmussen approved these changes May 31, 2018
View reviewed changes
Copy link
Contributor

@jasmussen jasmussen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed, this fixes it for me!

@gziolo gziolo merged commit 6c8ab9b into master May 31, 2018
@gziolo gziolo deleted the fix/babel-config-packages branch May 31, 2018 08:46
@gziolo gziolo mentioned this pull request May 31, 2018
Merged
3 tasks
@MaxMood96 MaxMood96 mentioned this pull request Jul 6, 2023
Open
This was referenced Jul 6, 2023
Open
Open
@soloinovator soloinovator mentioned this pull request Jul 6, 2023
Open
@captainbarber99 captainbarber99 mentioned this pull request Jul 7, 2023
Open
@yassine4999 yassine4999 mentioned this pull request Jul 7, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasmussen jasmussen jasmussen approved these changes

Assignees

@gziolo gziolo

Labels
npm Packages Related to npm packages [Type] Bug An existing feature does not function as intended [Type] Build Tooling Issues or PRs related to build tooling
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.
2 participants
@gziolo @jasmussen