Fix a typo in classic block, and scope Quote editor styles #7040
Conversation
core-blocks/quote/editor.scss
Outdated
| @@ -1,12 +1,13 @@ | |||
| .wp-block-quote { | |||
| .editor-block-list__block[data-type="core/image"] .wp-block-quote { | |||
There was a problem hiding this comment.
It looks like a bug here "core/image"? Also, be mindful that we should try to avoid these selectors because the .editor-block-list__block[data-type="core/*"]div is not rendered when you save the block as reusable breaking the styles when editing reusable blocks.
There was a problem hiding this comment.
Definitely a bug. Fixed typo, thanks.
Also, be mindful that we should try to avoid these selectors because the .editor-block-list__block[data-type="core/*"]div is not rendered when you save the block as reusable breaking the styles when editing reusable blocks.
Right — this would be for scoping editor-only styles. Any style that should be shown in both the editor and the front-end should presumably be in style.scss right?
There was a problem hiding this comment.
I think Riad is trying to explain that when you save your block as reusable (Saved) block, those rules won't be applied, because it is going to be controlled by data-type="data" matcher.
There was a problem hiding this comment.
Hmmmmmm. Okay, tricky. I'll remove this for now, but it'd be nice if there was a way to scope styles to be editor only.
There was a problem hiding this comment.
I think we use .gutenberg className to scope those for now.
|
Reverted the scoping for now. This is now just a classic editor typo fix. |
This PR does two things
It fixes a typo in the classic block
It scopes the editor quote styles to truly be editor-only.
Number 2 is important for implementations that might load Gutenberg itself on the front-end. Scoping the styles to be in-editor helps prevent CSS bleed to outside the editing canvas.
I would like your thoughts on this, because if 2 is approved, then perhaps we should use the same pattern for all other blocks. Right now were using a mixture of
.editor-block-list__block[data-type="core/blockname"]and.wp-block-blockname. If every editor style was scoped with the former, we'd truly keep it in-canvas, enhancing reusability.Let me know if this is a good plan, and I'll expand this PR with a few commits.
By the way this PR was done "blind", because I'm blocked on what I think is an issue with the build process currently: #7027 (comment)