Fix regression in Spacer block #7024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a typo in the rename of the drag handle and associated CSS class.
youknowriad
reviewed
May 30, 2018
core-blocks/spacer/index.js
Outdated
| @@ -47,8 +47,8 @@ export const settings = { | |||
| } } | |||
| minHeight="20" | |||
| handleClasses={ { | |||
| top: 'core-blocks-spacer__resize-handler-top', | |||
| bottom: 'core-blocks-spacer__resize-handler-bottom', | |||
| top: 'block-spacer__resize-handler-top', | |||
There was a problem hiding this comment.
I think you should update the stylesheet instead ;) These class names do not follow our guidelines ;)
There was a problem hiding this comment.
Sorry, I'm about to hop on a meeting, if you have bandwidth feel free to commandeer this PR :D
This was referenced May 30, 2018
The JS followed guidelines.
|
Sorry, that was a last-minute change I haven't checked properly. |
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in 59f2ad8, which made the resizing dots disappear from the spacer block. You could still resize, there just weren't any visual handles. This fixes that.
There was a typo in the rename of the drag handle and associated CSS class.