Repository navigation
Block drag & drop: Enable mouse click on input/textarea elements in Firefox - #69781
Merged
Merged
Conversation
t-hamano
added
[Type] Bug
|
Size Change: +29 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Regression
github-project-automation
Bot
moved this to 🔎 Needs Review
in WordPress 6.8 Editor Tasks
t-hamano
marked this pull request as ready for review
April 1, 2025 03:05
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
5 of 6 tasks
Mamaduka
approved these changes
Apr 1, 2025
github-project-automation
Bot
moved this from 🔎 Needs Review
to ✅ Done
in WordPress 6.8 Editor Tasks
gutenbergplugin
pushed a commit
that referenced
this pull request
Apr 1, 2025
…irefox (#69781) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: audrasjb <audrasjb@git.wordpress.org>
github-actions
Bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.8 branch to get it included in the next release: a3c46b7 |
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
…irefox (WordPress#69781) Co-authored-by: t-hamano <wildworks@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: audrasjb <audrasjb@git.wordpress.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #69779
Related PRs:
cc @ellatrix @youknowriad
What?
This PR fixes an issue where when a block contains
inputortextarea, its values cannot be selected with the mouseclick.Why?
This problem is related to the Firefox bug: - 965800 - Text cursor (caret) ignores mouse click on inputs with draggable parent
In Firefox, the
draggableandcontenteditableattributes don't play well. Therefore, there is logic inside it that removes thedraggableattribute when you click inside thecontenteditableelement.However, this logic does not apply to
inputandtextareaelements, as they do not have thecontenteditableattribute, even though they have text that is clickable with the mouse.How?
Add a check whether the clicked element is
inputortexteareaelement or not. I would have liked to use theisInputOrTextArea()function, but it's not exposed.Testing Instructions
Core Blocks
HTML Native Elements
Paste the following code into the browser console panel. If you can't paste, access
about:configand setdom.event.clipboardevents.enabledtofalse.Code
input[type="number"]textareaScreenshots or screencast
Berfore
84ea1887334476819d79f8e40b548df8.mp4
After
83f45e60ceb5b6b555218db6e3f360f3.mp4