Skip to content

Query Total: Prevent stricted type fatal errors on post per page. #69508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Query Total: Prevent stricted type fatal errors on post per page. #69508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df43192
Force post per page to be an integer
cbravobernal Mar 10, 2025
343bb4c
Cast get_query_var return value to int
Mamaduka Mar 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/block-library/src/query-total/index.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,15 +23,15 @@ function render_block_core_query_total( $attributes, $content, $block ) {
$wrapper_attributes = get_block_wrapper_attributes();
if ( isset( $block->context['query']['inherit'] ) && $block->context['query']['inherit'] ) {
$query_to_use = $wp_query;
$current_page = max( 1, get_query_var( 'paged', 1 ) );
$current_page = max( 1, (int) get_query_var( 'paged', 1 ) );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The get_query_var also uses WP_Query::get under the hood and ``min( 1, '0' )will return"0"`.

} else {
$page_key = isset( $block->context['queryId'] ) ? 'query-' . $block->context['queryId'] . '-page' : 'query-page';
$current_page = isset( $_GET[ $page_key ] ) ? (int) $_GET[ $page_key ] : 1;
$query_to_use = new WP_Query( build_query_vars_from_query_block( $block, $current_page ) );
}

$max_rows = $query_to_use->found_posts;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also cast this value just to be on the safe side?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think found_posts is already set as int on the query object.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed that found_posts is always set as int.

What about $current_page = max( 1, get_query_var( 'paged', 1 ) );? In particular, I'm worried about get_query_var as it has a mixed return value.

$posts_per_page = $query_to_use->get( 'posts_per_page' );
$posts_per_page = (int) $query_to_use->get( 'posts_per_page' );

// Calculate the range of posts being displayed.
$start = ( $current_page - 1 ) * $posts_per_page + 1;
Expand Down
Loading