Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove trailing periods from Show or hide settings panel #69356

Conversation

Infinite-Null
Copy link
Contributor

@Infinite-Null Infinite-Null commented Feb 27, 2025

What?

This PR removes the trailing period from the command palette description for the Settings panel toggle.
Closes #69354

Why?

Modified the string Show or Hide the Settings panel. to remove the trailing period. This ensures consistency in the command palette UI.

Testing Instructions

  1. Edit or create a new page
  2. Open Command by Super + k
  3. Search for show and see if Show or hide the Settings panel has trailing period

Screenshots

Before After
image image

@t-hamano t-hamano added [Type] Enhancement A suggestion for improvement. [Type] Command Palette labels Feb 27, 2025
@Infinite-Null Infinite-Null marked this pull request as ready for review February 28, 2025 05:42
Copy link

github-actions bot commented Feb 28, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Infinite-Null <[email protected]>
Co-authored-by: t-hamano <[email protected]>
Co-authored-by: shail-mehta <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@shail-mehta shail-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@shail-mehta shail-mehta added the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 1, 2025
@github-actions github-actions bot removed the props-bot Adding this label triggers the Props Bot workflow for a PR. label Mar 1, 2025
@shail-mehta shail-mehta merged commit 4e3b759 into WordPress:trunk Mar 1, 2025
64 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.5 milestone Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Command Palette: Remove the period from the end of the action
3 participants