Repository navigation
Leverage @wordpress/base-styles admin schemes stylesheet instead of duplicate declarations in various packages #69130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
a71c91a
add built base admin color schemes built file that can be consumed by…
fabiankaegy 83ea0b4
register new wp-admin-schemes handle in 6.8 compat folder
fabiankaegy 7fc49fe
ensure base styles package is included in built folder
fabiankaegy a968008
replace instances of `wordpress-admin-schemes` mixin with `wp-admin-s…
fabiankaegy 54d611e
Merge branch 'trunk' into feature/leverage-build-base-styles
fabiankaegy 9b533d6
Update lib/compat/wordpress-6.8/script-loader.php
fabiankaegy 08a7776
Merge branch 'trunk' into feature/leverage-build-base-styles
fabiankaegy 53bacb4
move to 6.9 folder
fabiankaegy 3fa808e
add backport link
fabiankaegy 757f548
Merge branch 'trunk' into feature/leverage-build-base-styles
fabiankaegy 8095112
fix update path
fabiankaegy 63f03bc
remove css import from commands styles
fabiankaegy e4e44f2
fix update paths
fabiankaegy 4691992
fix remove redundant overrided
fabiankaegy 51db664
further simplify
fabiankaegy 25d42a4
fix package config for new build system
fabiankaegy 78b83d8
fix style url
fabiankaegy b94eb51
fix load base styles for block-library
fabiankaegy d77918a
fix move styles
fabiankaegy 141927d
Merge branch 'trunk' into feature/leverage-build-base-styles
fabiankaegy b07676a
fix simplify
fabiankaegy 64f77bf
fix add back accidentally removed override
fabiankaegy 0dcec76
Merge branch 'trunk' into feature/leverage-build-base-styles
fabiankaegy 9397ad2
fix, simplify loading of base styles
fabiankaegy 6fceeb2
fix include exports of all source sass files
fabiankaegy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| <?php | ||
| /** | ||
| * WordPress scripts and styles default loader. | ||
| * | ||
| * @package gutenberg | ||
| */ | ||
|
|
||
| add_action( 'wp_default_styles', 'gutenberg_register_admin_schemes_stylesheet' ); | ||
|
|
||
| /** | ||
| * Register the base styles asset. | ||
| * | ||
| * @param WP_Styles $styles WP_Styles instance. | ||
| */ | ||
| function gutenberg_register_admin_schemes_stylesheet( $styles ) { | ||
|
|
||
| $styles->add( | ||
| 'wp-admin-schemes', | ||
| gutenberg_url( 'build/base-styles/admin-schemes.css' ) | ||
| ); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| @include wordpress-admin-schemes(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -51,5 +51,3 @@ body.js.block-editor-page { | |
| height: auto; | ||
| } | ||
| } | ||
|
|
||
| @include wordpress-admin-schemes(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -93,5 +93,3 @@ body.js.site-editor-php { | |
| top: 0; | ||
| } | ||
| } | ||
|
|
||
| @include wordpress-admin-schemes(); | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -7,5 +7,3 @@ | |
| position: relative; | ||
| top: -3px; | ||
| } | ||
|
|
||
| @include wordpress-admin-schemes(); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.