Site Editor: Have useNavigateToPreviousEntityRecord rely on location state
#69103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +4 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
stokesman
added
[Type] Bug
|
Flaky tests detected in 01b9ab3. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/13208805380
|
stokesman
commented
Feb 8, 2025
Comment on lines
+6
to
+7
| import type { ReactNode } from 'react'; | ||
| import type { Location } from 'history'; |
There was a problem hiding this comment.
- Moved 'react' import up from below
- Added
Locationtype import—Locationwas referenced before but since it wasn’t imported it was resolving to Typescript’s lib-dom which is different.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Closes #69016
Makes the code concerned with whether to show a back button more robust.
Why?
In focused editing a back button should appear in the Document bar when arriving from another edit view. Currently the code concerned with this relies on the
usePrevioushook and is within a part of the component tree that may remount. A remount resets the hook’s state and that causes failure of the logic to display the back button. There are more reasons to avoid the use of theusePrevioushook:How?
useNavigateToEntityRecordto store the state that was kept byusePreviousin the the router’slocation.statelocation.statethrough theuseLocationhooknavigateToPreviousEntityRecordto use the new state from the routerTesting Instructions