Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix editor loading state shows flash of incorrect rendering mode #69099

Draft
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

Mayank-Tripathi32
Copy link
Contributor

attempt fix #69088
related #68110

What?

Address editor rendering mode initialization issue identified in #69088.

Why?

Current implementation delays setting default rendering mode until template loads, causing "post-only" state to be set temporarily.

How?

Modify default mode initialization to:

	defaultMode: hasDefaultMode ? _defaultMode : 'post-only';

This maintains mode validation while removing template dependency.

Testing Instructions

  • Open editor with a template-supported post type
  • Verify rendering does not flash the "post-only" page view.
  • Confirm mode switches correctly between post-only and template-locked states
  • Test with various post types to ensure proper mode initialization

ScreenCast

loading.issue.mov

@Mayank-Tripathi32
Copy link
Contributor Author

	[ post.type, hasTemplate ]

Also, I noticed a bit of performance diff if I removed hasTemplate, not sure if it can measured.

@Mamaduka Mamaduka added [Type] Regression Related to a regression in the latest release [Package] Editor /packages/editor labels Feb 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Editor /packages/editor [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Editor loading state shows flash of incorrect rendering mode
2 participants