Skip to content

Fix: Menu: reconsider the modal behavior - #68930

Closed
Rishit30G wants to merge 1 commit into
WordPress:trunkfrom
Rishit30G:fix/menu-modal-behaviour
Closed

Rishit30G wants to merge 1 commit into
WordPress:trunkfrom
Rishit30G:fix/menu-modal-behaviour

Conversation

@Rishit30G

Copy link
Copy Markdown
Contributor

What?

Fixes #68830

Why?

As discussed in the accessibility bug scrub, The modal behavior is unnecessary, it would be better if the menus did not behave as modals.

How?

This PR adds modal = {false} to Menu.Popover to prevent the modal like behaviour in the Page Section

Testing Instructions

  • Go the editor
  • Go to Pages
  • Open the actions dropdown
  • Observe that the modal behaviour is absent and one can easily select other items present on the page despite the dropdown being open

Screenshots or screencast

Screen.Recording.2025-01-29.at.8.36.40.AM.mov

@github-actions

github-actions Bot commented Jan 29, 2025 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Rishit30G <rishit30g@git.wordpress.org>
Co-authored-by: joedolson <joedolson@git.wordpress.org>
Co-authored-by: carolinan <poena@git.wordpress.org>
Co-authored-by: afercia <afercia@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta added [Type] Bug An existing feature does not function as intended [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components labels Jan 29, 2025
@Rishit30G

Copy link
Copy Markdown
Contributor Author

I just wanted to check if everything looks good or if there are any improvements we should consider 🙇🏻
cc: @carolinan

@youknowriad

Copy link
Copy Markdown
Contributor

Thanks @Rishit30G for picking this up after the a11y bug scrub! DataViews now uses the Menu component from @wordpress/ui (#81783), so the Menu.Popover this patches no longer exists. Whether the menu should be modal is still under discussion in #68830 (see mirka's note about scrolling). I'm closing this as obsolete. If you'd like to continue, a fresh PR against the new Menu.Root is very welcome once there's agreement on the issue.

@youknowriad youknowriad closed this Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). [Package] Components /packages/components [Type] Bug An existing feature does not function as intended

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Menu: reconsider the modal behavior

3 participants