Repository navigation
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
I just wanted to check if everything looks good or if there are any improvements we should consider 🙇🏻 |
|
Thanks @Rishit30G for picking this up after the a11y bug scrub! DataViews now uses the |
What?
Fixes #68830
Why?
As discussed in the accessibility bug scrub, The modal behavior is unnecessary, it would be better if the menus did not behave as modals.
How?
This PR adds
modal = {false}toMenu.Popoverto prevent the modal like behaviour in the Page SectionTesting Instructions
Screenshots or screencast
Screen.Recording.2025-01-29.at.8.36.40.AM.mov