Repository navigation
e2e:fix WP Editor Meta Boxes test - #68872
Merged
Merged
Conversation
t-hamano
marked this pull request as ready for review
January 24, 2025 09:45
t-hamano
added
the
[Type] Automated Testing
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: 0 B Total Size: 1.84 MB ℹ️ View Unchanged
|
Contributor
Author
|
All tests pass, the cause is clear, so I will merge this PR. |
zaguiini
pushed a commit
that referenced
this pull request
Feb 5, 2025
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
cbravobernal
added a commit
that referenced
this pull request
Feb 6, 2025
#69058) * iAPI Router: Fix CSS rule order in some constructed style sheets (#68923) * Add failing test * Place CSS rules in order Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org> Co-authored-by: sethrubenstein <smrubenstein@git.wordpress.org> * Plugin: Remove ESLint rule for deprecated functions (#68590) Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> * e2e:fix WP Editor Meta Boxes test (#68872) Co-authored-by: t-hamano <wildworks@git.wordpress.org> --------- Co-authored-by: David Arenas <david.arenas@automattic.com> Co-authored-by: DAreRodz <darerodz@git.wordpress.org> Co-authored-by: luisherranz <luisherranz@git.wordpress.org> Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org> Co-authored-by: sethrubenstein <smrubenstein@git.wordpress.org> Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com> Co-authored-by: fabiankaegy <fabiankaegy@git.wordpress.org> Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com> Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Kallyan01
pushed a commit
to Kallyan01/gutenberg
that referenced
this pull request
Feb 24, 2025
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
chriszarate
pushed a commit
to chriszarate/gutenberg
that referenced
this pull request
Jul 1, 2025
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Aug 31, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 10, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 10, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 11, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 14, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 14, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
desrosj
added a commit
to desrosj/gutenberg
that referenced
this pull request
Sep 14, 2026
…on-name selector. The previous commit ported `WordPress#78631`'s TinyMCE initialization wait, on the assumption the failure was a race between the meta box's TinyMCE iframe appearing and the editor finishing initialization. Verified against real CI, that fix did not resolve the failure: it still timed out at the same `role=button[name="Code"i]` click, now after the added `waitForFunction` had already resolved successfully. The actual cause is a button-label mismatch, unrelated to any timing race. The "Code"/"Text" toggle is rendered by WordPress Core's `wp_editor()` (`wp-includes/class-wp-editor.php`), and `wp-env`'s pinned core for this branch, `WordPress/WordPress#6.7-branch`, still ships the string `_x( 'Text', 'Name for the Text editor tab (formerly HTML)' )`. Core renamed this label to "Code" only on its own `master` branch (`_x( 'Code', 'Name for the Code editor tab (formerly Text)' )`) after `6.7-branch` was cut, and never backported the wording change to the maintenance branch. Screenshots from every failed run (the original cited run and the one testing the previous, ineffective commit) confirm the rendered button reads "Text", not "Code". The underlying behavior is identical either way, so using the correct label is a like-for-like change, not a weakened assertion. The Gutenberg plugin's own trunk renamed this locator from "Text" to "Code" in `WordPress#68872`/`WordPress#68886` (Jan 2025), correctly following its own trunk's newer bundled/tested core. That rename doesn't apply on `wp/6.7`, whose `wp-env` config intentionally pins to the matching `6.7-branch` core, so this reverts the locator back to "Text" for this branch and drops the TinyMCE-`waitForFunction` addition along with it, since the original iframe-existence wait was never the actual problem: the failure was 100% reproducible, not intermittent, which is what a hard-coded wrong locator produces and a genuine race condition would not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
In the following changeset, the
Texttab in the classic editor has been changed toCode. As a result, the selectors in e2e tests need to be updated.https://core.trac.wordpress.org/changeset/59696
Testing Instructions
It should pass all e2e tests.