Skip to content

Blocks: Standardise Media Section in Block's Inspector Panel - #68606

Closed
im3dabasia wants to merge 3 commits into
WordPress:trunkfrom
im3dabasia:feat/66563
Closed

im3dabasia wants to merge 3 commits into
WordPress:trunkfrom
im3dabasia:feat/66563

Conversation

@im3dabasia

@im3dabasia im3dabasia commented Jan 10, 2025 •

Copy link
Copy Markdown
Contributor

Work in Progress

Closes: #66563

What?

Why?

How?

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

Before After

@Mamaduka

Copy link
Copy Markdown
Member

@im3dabasia, let's link the issue this PR tries to fix.

Here are a couple of things to consider before moving forward:

@im3dabasia

Copy link
Copy Markdown
Contributor Author

@im3dabasia, let's link the issue this PR tries to fix.

Thank you, @Mamaduka. I’ve updated the issue this PR addresses.

This PR aims to standardize the Media section settings across the Image block, Media & Text block, and Cover block. The objective is to align these settings within the Inspector Controls panel, following the structure already implemented in the Site Logo block.

Would you recommend raising separate PRs for the changes in each block, or would a single comprehensive PR be more appropriate? I will also review the updates in #68621 and make adjustments to ensure alignment with the latest changes.

Looking forward to hearing your thoughts.

@Mamaduka

Copy link
Copy Markdown
Member

A single PR is fine as long as it's easy to review. This is why I suggested extracting logic into a private component that blocks can reuse.

@Mamaduka Mamaduka added [Type] Enhancement A suggestion for improvement. [Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media labels Jan 13, 2025
@im3dabasia

Copy link
Copy Markdown
Contributor Author

Closing this as it is superceeded by #82751 and #82593

@im3dabasia im3dabasia closed this Sep 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Feature] Blocks Overall functionality of blocks [Feature] Media Anything that impacts the experience of managing media [Type] Enhancement A suggestion for improvement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Block setup states: Include both inspector and toolbar options for setting and resetting

2 participants