Skip to content

env: Fix changelog entry - #68219

Merged
t-hamano merged 1 commit into
trunkfrom
env/fix-changelog-multisite
Dec 22, 2024
Merged

t-hamano merged 1 commit into
trunkfrom
env/fix-changelog-multisite

Conversation

@t-hamano

Copy link
Copy Markdown
Contributor

What?

Multisite support was added via #67845. This PR is part of Gutenberg 20.0 and is not released yet, so it should be added to the Unreleased section. At the same time, I linked the PR link to the changelog about multisite, phpmyAdmin.

Testing Instructions

See: https://github.com/WordPress/gutenberg/blob/d619c3667d920736ffe56c1f84209f671bcb08e8/packages/env/CHANGELOG.md

@t-hamano t-hamano added the [Type] Developer Documentation Documentation for developers label Dec 22, 2024
@t-hamano
t-hamano requested review from gziolo and mcsf December 22, 2024 01:55
@t-hamano
t-hamano marked this pull request as ready for review December 22, 2024 01:56
@github-actions

github-actions Bot commented Dec 22, 2024 •

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: ryanwelcher <welcher@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@github-actions

Copy link
Copy Markdown

Flaky tests detected in d619c36.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12450260139
📝 Reported issues:

@t-hamano t-hamano self-assigned this Dec 22, 2024

@ryanwelcher ryanwelcher left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano
t-hamano merged commit 52a8062 into trunk Dec 22, 2024
@t-hamano
t-hamano deleted the env/fix-changelog-multisite branch December 22, 2024 03:55
@github-actions github-actions Bot added this to the Gutenberg 20.0 milestone Dec 22, 2024
@mcsf

mcsf commented Dec 23, 2024

Copy link
Copy Markdown
Contributor

Oh, that was clumsy of me! Good spot, and thanks for the fix. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

[Type] Developer Documentation Documentation for developers

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants