-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DON'T MERGE - Just testing an alternative to #62304 #67017
Closed
fabiankaegy
wants to merge
51
commits into
trunk
from
try/default-rendering-mode-without-default-change
Closed
DON'T MERGE - Just testing an alternative to #62304 #67017
fabiankaegy
wants to merge
51
commits into
trunk
from
try/default-rendering-mode-without-default-change
+196
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…deringMode value into the Editor rendering function.
…perty to read default_rendering_mode.
…). Add the post type editor mode logic to the root editor package and save in store.
Adding fixes for failing tests
# Conflicts: # lib/load.php # packages/e2e-test-utils-playwright/src/editor/index.ts # packages/edit-site/src/components/block-editor/use-site-editor-settings.js # packages/editor/src/components/provider/index.js
fabiankaegy
deleted the
try/default-rendering-mode-without-default-change
branch
November 14, 2024 23:34
Size Change: +13 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only here to test if the tests in #62304 are failing because we also change the default rendering mode. This PR does not contain that change. Everything else is the same