Cover: Fix media library image selection #66782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +39 B (0%) Total Size: 1.82 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 9b09c91. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11697467717
|
aaronrobertshaw
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks for the quick fix @Mamaduka 🚀
✅ Typo fix works as advertised
✅ Rest API upload fix works
LGTM 🚢
|
Thanks for testing and review, @aaronrobertshaw 🙇 I'm going to merge this. The long-running RN Andoind test is a known issue (#66771). |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
* Cover: Fix media library image selection * Fix sizes for uploaded images Co-authored-by: Mamaduka <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]> Co-authored-by: richtabor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #66765.
A regression after #62926.
PR fixes a regression when selecting an image from the Media Library didn't set the
urlattribute for the cover block. I've also fixed the logic for derivingsizeSlugandurlattributes during direct uploads.Re 9b09c91 - The media object returned by Library selection and REST API upload have different shapes.
The fixes are in atomic commits, which should make reviewing easier.
Testing Instructions
imageDefaultSize(default:large) size.large).Testing Instructions for Keyboard
Same.