Navigation: Improve trigger for fallback navigation #66478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Code Quality
tyxla
requested review from
draganescu,
Mamaduka,
scruffian,
getdave,
ntsekouras and
a team
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -21 B (0%) Total Size: 1.81 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in b19aae9. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11519476541
|
Mamaduka
reviewed
Oct 25, 2024
| // If there is no navigation menu found | ||
| // then trigger fallback algorithm to create one. | ||
| if ( | ||
| ! firstNavigationMenu && | ||
| ! isResolvingNavigationMenus && | ||
| hasResolvedNavigationMenus && | ||
| ! hasCreatedFallback | ||
| // Ensure a fallback navigation is created only once | ||
| ! isCreatingNavigationFallback | ||
| ) { | ||
| getNavigationFallbackId(); |
There was a problem hiding this comment.
Calling a selector during the render seems odd. I know that useSelect isn't the best place to "fire and forget" pattern, but I can't think of a better alternative.
There was a problem hiding this comment.
I admit that's weird, however, with the mechanics of selectors and resolvers, it does make sense to some degree. It's also documented why we're doing it, so it felt OK to leave as-is. This PR attempts to only fix the React Compiler error after all.
|
Juts for history: the flag removed in this PR was added in #51413 not in #50321 in this commit. |
draganescu
approved these changes
Oct 28, 2024
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: tyxla <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: draganescu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Come up with an alternative solution for solving the problem #50321 intends to solve.
Why?
#50321 uses an external flag for the component, which is against React's rules, and the React Compiler doesn't appreciate it (see #61788).
How?
The goal of #50321 was to create fallback navigation only if there were no navigations at all, and create it only once for the session.
This PR achieves it by checking if the request to create a fallback navigation is currently resolving. This simplifies the logic by avoiding an extra flag, and satisfies the React Compiler.
Testing Instructions
Same as in #50321.
Testing Instructions for Keyboard
Same
Screenshots or screencast
None