Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix text editor style regression #662

Merged
merged 1 commit into from
May 4, 2017
Merged

Fix text editor style regression #662

merged 1 commit into from
May 4, 2017

Conversation

jasmussen
Copy link
Contributor

This is a PR to fix a regression I introduced in #603 (review).

This moves the styles to input fields to be scoped to blocks, and the sidebar, both of which will benefit from this style.

@jasmussen
Fix text editor style regression
f2c953c 
This is a PR to fix a regression I introduced in #603 (review).

This moves the styles to input fields to be scoped to blocks, and the sidebar, both of which will benefit from this style.
@jasmussen jasmussen added [Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended labels May 4, 2017
@jasmussen jasmussen self-assigned this May 4, 2017
@jasmussen jasmussen requested a review from aduth May 4, 2017 15:00
@jasmussen jasmussen mentioned this pull request May 4, 2017
Merged
aduth
aduth approved these changes May 4, 2017
View reviewed changes
Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear whether this belongs in the "root" stylesheet vs. individually per sidebar and visual editor components (maybe with mixin), but this seems fine enough 👍

@jasmussen jasmussen merged commit fea2a89 into master May 4, 2017
@jasmussen jasmussen deleted the fix/text-editor-regression branch May 4, 2017 15:17
@jasmussen
Copy link
Contributor Author

Unclear whether this belongs in the "root" stylesheet vs. individually per sidebar and visual editor components (maybe with mixin), but this seems fine enough 👍

Yep, was unsure as well, but decided to go with the root stylesheet to avoid duplication of the styles.

@yaseenaljamal yaseenaljamal mentioned this pull request Dec 17, 2023
Open
@petrescugit petrescugit mentioned this pull request Dec 17, 2023
Open
@soloinovator soloinovator mentioned this pull request Dec 17, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduth aduth aduth approved these changes

Assignees

@jasmussen jasmussen

Labels
[Feature] Blocks Overall functionality of blocks General Interface Parts of the UI which don't fall neatly under other labels. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jasmussen @aduth