-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactivity: Update preact packages #66008
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Size Change: +652 B (+0.04%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Is there any compelling reason to still include it in WordPress 6.7? |
I don't think so. There are a number of bug fixes across the different packages but I don't know of anything specifically that impacts the Interactivity API. |
I would leave this for 6.8 so we have plenty of time to test. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Update preact packages * Update package-lock * Fix some EffectFn types * Remove outdated ts-expect-error * Add changelog Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: cbravobernal <[email protected]>
* Update preact packages * Update package-lock * Fix some EffectFn types * Remove outdated ts-expect-error * Add changelog Co-authored-by: sirreal <[email protected]> Co-authored-by: gziolo <[email protected]> Co-authored-by: cbravobernal <[email protected]>
What?
Full preact changelog
Why?
These dependencies are essential for Interactivity API and continue to improve.
How?
Update.
Testing Instructions
End to end tests on CI are likely sufficient.