Query loop format controls: Fix JavaScript error #65551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
carolinan
added
Backport to WP 6.7 Beta/RC
|
Size Change: +70 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
Mamaduka
reviewed
Sep 24, 2024
| @@ -68,7 +68,7 @@ export default function FormatControls( { onChange, query: { format } } ) { | |||
| .filter( Boolean ); | |||
|
|
|||
| const suggestions = formats | |||
| .filter( ( item ) => ! format.includes( item.value ) ) | |||
| .filter( ( item ) => ! normalizedFormats.includes( item.value ) ) | |||
There was a problem hiding this comment.
Just to refresh my memory, this filter removes values from the suggestions already assigned to the Query, correct?
There was a problem hiding this comment.
Yes.
Shall I add a comment about it? I still need to create a new PR to apply the changes requested in the review of the sync with core, I could add it then.
There was a problem hiding this comment.
There's no need for a comment. I was just double checking for myself 😄
Mamaduka
approved these changes
Sep 24, 2024
carolinan
added
the
Backport to Gutenberg RC
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 25, 2024
Fixes a JavaScript error in FormatControls by ensuring that the correct constant is used when populating the suggestions in the FormTokenField. Co-authored-by: carolinan <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: annezazu <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 4081b90 |
peterwilsoncc
added
the
Backport to WP 6.7 Beta/RC
|
There was a conflict while trying to cherry-pick the commit to the wp/6.7 branch. Please resolve the conflict manually and create a PR to the wp/6.7 branch. PRs to wp/6.7 are similar to PRs to trunk, but you should base your PR on the wp/6.7 branch instead of trunk. |
peterwilsoncc
removed
the
Backport to WP 6.7 Beta/RC
kevin940726
pushed a commit
that referenced
this pull request
Sep 25, 2024
Fixes a JavaScript error in FormatControls by ensuring that the correct constant is used when populating the suggestions in the FormTokenField. Co-authored-by: carolinan <[email protected]> Co-authored-by: Mamaduka <[email protected]> Co-authored-by: annezazu <[email protected]>
|
I just cherry-picked this PR to the release/19.3 branch to get it included in the next release: 35f0201 |
kevin940726
removed
the
Backport to Gutenberg RC
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #65550.
This PR fixes a JavaScript error that happens in the
FormatControlsin the query loop block when theformatparameter in thequeryblock attribute is not anarray.This error can occur for example when an existing query loop pattern is placed in a post or page, for example
when a block pattern with a query loop is added. Presumably because the 'format' is missing in these existing patterns.
Why? & How
FormatControlsalready creates a constant callednormalizedFormatswith the purpose of ensuring thatformatis anarray. - But it was not used in all instances where it was needed:This PR updates
FormatControlsto usenormalizedFormatsfor creating the list of suggested formats in theFormTokenField.Testing Instructions
First please enable post format support in the active theme, for example in functions.php.
Example:
Add some test posts, both with and without post formats assigned.
-If you are using Twenty Twenty-Four, test a page pattern:
Create a new page: You will be prompted with a modal when you create a new page.
In this modal, select the pattern "Portfolio Home with post featured images".
In this portfolio design there are multiple query loop blocks.
Open the ListView to locate the query loops easier.
Select a query loop and then open the Filters panel in the block settings sidebar.
In the Filters panel, click on "Formats".
Confirm that there are no block validation errors or other issues:
A new input field should show in the Filters panel.
Select the input field, and type or select a post format name.
Confirm that the query loop displays the selected format.
Test an inserted pattern (any theme)
Create a new post or page.
Open the block inserter in top left corner, and select the Patterns tab.
Select the "Posts" pattern category, and insert any pattern from this list.
Select a query loop and then open the Filters panel in the block settings sidebar.
In the Filters panel, click on "Formats".
Confirm that there are no block validation errors or other issues:
A new input field should show in the Filters panel.
Select the input field, and type or select a post format name.
Confirm that the query loop displays the selected format.