Block Bindings: Unify logic in getPostMetaFields function
#65462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Code Quality
SantosGuillamot
requested review from
gziolo,
artemiomorales and
cbravobernal
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: -35 B (0%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
gziolo
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Code wise this looks nice as there is only one place with the complex logic to collect data and map to the structure needed in other places. I would appreciate some help with testing from @cbravobernal or @artemiomorales.
| }, | ||
| ] ) | ||
| ); | ||
| return getPostMetaFields( registry, context ); |
gziolo
added
Backport to Gutenberg RC
Co-authored-by: Greg Ziółkowski <[email protected]>
Co-authored-by: Greg Ziółkowski <[email protected]>
SantosGuillamot
force-pushed
the
update/unify-functions-in-post-meta-source
branch
from
1f1c2b4
to
e4d1a70
Compare
|
Flaky tests detected in e4d1a70. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/11030093440
|
cbravobernal
approved these changes
Sep 25, 2024
github-actions
bot
removed
the
Backport to WP 6.7 Beta/RC
gutenbergplugin
pushed a commit
that referenced
this pull request
Sep 25, 2024
* Move logic to `getPostMetaFields` function * Update comment to use third-person Co-authored-by: Greg Ziółkowski <[email protected]> * Remove extra space from comment object Co-authored-by: Greg Ziółkowski <[email protected]> * Use props variable --------- Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: gziolo <[email protected]>
github-actions
bot
added
the
Backported to WP Core
|
I just cherry-picked this PR to the wp/6.7 branch to get it included in the next release: 592d717 |
gziolo
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
There is some improvement over how the post meta source is defined as reported in the following comments:
register_metain block bindings workflows #65099 (comment)register_metain block bindings workflows #65099 (comment)In this pull request, I explored a slightly different approach to the
getPostMetaValueshelper, changing also its name and adding some docs.Why?
Code is tricky to understand and this could help navigating and modifying it.
How?
There are a few aspects to take into account:
nullwhen the list is empty.value, the fallback to label or key can't be abstracted because that is only wanted ingetValuesand not in the list of fields shown bygetFieldsList.type === "wp_template"because I am not sure if it is necessary. With the new code we try to get the entityRecord values and if not, fall back to how the field has been registered. I could add a check if we consider it safer.Testing Instructions
Everything should keep working as before and e2e tests should pass.