Terms List block: Add Categories-specific variation #65434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ockham
added
[Type] Enhancement
gziolo
reviewed
Sep 18, 2024
| name: 'terms', | ||
| title: __( 'Terms List' ), | ||
| icon, | ||
| attributes: { |
There was a problem hiding this comment.
If you add isDefault: true to this variation, then it will resolve the issue with double entries in the inserter. That should make it quite a compelling solution to the problem I like how you handled the Categories vs the rest case.
There was a problem hiding this comment.
Maybe the name for the property should be phrased differently, but the intent is to have a simple way to change the default version of the block in the UI through the variation, instead of using WP filters.
gziolo
reviewed
Sep 18, 2024
| const taxonomies = allTaxonomies?.filter( | ||
| ( t ) => | ||
| t.visibility.public && | ||
| ( taxonomySlug === 'category' ) === ( t.slug === 'category' ) |
There was a problem hiding this comment.
What is the risk if the `category is listed here? When switching a choice a different block variation would get selected but otherwise it should remain seamless for the user.
There was a problem hiding this comment.
Yeah, @fabiankaegy also suggested that over here. I'll quote my reply here for convenience:
TBH, that would feel inconsistent to me in terms of UX; I think it would be somewhat surprising to the user if selecting "Categories" as the taxonomy from that dropdown gets special treatment, while all other taxonomies don't 😕
I'm open to revisiting this. It's something I'd like to get feedback from designers on, though.
There was a problem hiding this comment.
I've tentatively applied this change in 9f70db6. We can revert, depending on the feedback we get.
There was a problem hiding this comment.
I've updated the screencast in the PR description accordingly.
Here's the previous one (with Categories removed from the dropdown)
|
Size Change: +89 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
gziolo
approved these changes
Sep 18, 2024
There was a problem hiding this comment.
Either way it's a nice improvement that ensures that folks familiar with the Categories block will be able to continue using it as before. For the rest, Terms List will serve as a great way to pick a proper taxonomy type.
I'll leave the decision about including the categories option in the combo box to other contributors. It's also an easy change to apply later based on the feedback from users.
|
Flaky tests detected in 9f70db6. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10918171883
|
fabiankaegy
approved these changes
Sep 18, 2024
|
Well, this has two approvals, and seems to remove some confusion around where the old Categories List block went without any major negative side effects, so I'm going to merge this. Thanks @gziolo and @fabiankaegy! I'm starting to wonder if at some point it'll make sense to really introduce one variation per taxonomy -- I think the main counter-argument against #64805 was the "Transform to" dropdown, but I've since learned that we can remove that by excluding |
|
This was also my thinking that we don’t have to show the transform combo box by removing the scope from variations. |
This was referenced Sep 26, 2024
This was referenced Sep 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Add two variations to the Terms List block (i.e.
core/categoriesand named "Categories List" prior to #65272): One for Categories, and another one for all other taxonomies.Why?
Mostly for better discoverability of what used to be the Categories List block under its new name. For more background, please refer to this thread.
How?
By creating two block variations.
Drawbacks
Also discussed in this thread.
Alternatives
One alternative would be to create a block variation for each individual taxonomy. This has been explored in #64805. (That PR is now closed, but it can be reopened anytime.)
Testing Instructions
TBD, but largely similar to #65272 or #64805.
Screenshots or screencast