Cover Block: Refactor setting panel #65432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akasunil
added
[Type] Enhancement
|
Size Change: +115 B (+0.01%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
…nt/refactor-cover-block-control
aaronrobertshaw
approved these changes
Oct 11, 2024
There was a problem hiding this comment.
Thanks for splitting this refactor out into its own PR @akasunil 👍
The change to using a ToolsPanel is working as expected for me.
While testing I did notice some weird behaviour and edge cases but this also happens on trunk without the ToolsPanel. This behaviour included:
- It seems odd that a fixed background toggles off the focal point controls but a repeated and fixed background doesn't. This is the same as trunk so 🤷
- If you set >= 100% for the focal point left's value, a horizontal scrollbar in the inspector is triggered. This wasn't introduced in this PR though
- If the focal point values are greater than 100%, resetting them should make the visible default value 50% however the field still contains 100%. This is the same as trunk without the ToolsPanel but it could be argued this PR makes it more prominent given the ToolsPanel's reset menu.
All these might be best addressed as follow-ups in separate PRs to keep this one focused only on the ToolsPanel refactor.
To that end, I think this is fine to land.
✅ Panel doesn't display for overlay only cover blocks
✅ Panel functions correctly for image overlays
✅ Correct controls present when using feature image in Cover block
✅ Correct controls displayed when using video block
LGTM 🚢
Screen.Recording.2024-10-11.at.12.41.29.pm.mp4
|
Thank you @aaronrobertshaw, for your approval. I'll merge this PR and rebase the PR #62926 I'll investigate the edge cases you mentioned and, if necessary, establish a new issue or follow-up PR to deal with them. |
karthick-murugan
pushed a commit
to karthick-murugan/gutenberg
that referenced
this pull request
Nov 13, 2024
Co-authored-by: akasunil <[email protected]> Co-authored-by: aaronrobertshaw <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Split from #62926
Why?
IWhile working on implementation of Resolution option in cover block, Its appeared that
ResolutionToolscomponent is composed ofToolsPanelItem, it must be placed inside theToolsPanelcomponent. The current Settings panel does not use the ToolsPanel component, so the entire settings panel is refactored.Testing Instructions
Screenshots or screencast