Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tabs: fix vertical indicator #65385

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Tabs: fix vertical indicator #65385

merged 2 commits into from
Sep 17, 2024

Conversation

DaniGuardiola
Copy link
Contributor

@DaniGuardiola DaniGuardiola commented Sep 17, 2024 •
edited
Loading

What?

Fix a regressiong that caused the vertical indicator to disappear.

How?

It was a typo. My bad!

Testing Instructions

Try vertical tabs in the Storybook.

Screenshots or screencast

Before:

{951FD2C5-919D-4150-A7DE-382BDF31FFCA}

After:

{F2625813-1207-4161-A204-7887C6B78161}

@DaniGuardiola DaniGuardiola requested a review from a team September 17, 2024 05:30
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: DaniGuardiola <[email protected]>
Co-authored-by: tyxla <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@DaniGuardiola DaniGuardiola added [Type] Bug An existing feature does not function as intended [Package] Components /packages/components labels Sep 17, 2024
@DaniGuardiola DaniGuardiola self-assigned this Sep 17, 2024
@DaniGuardiola DaniGuardiola mentioned this pull request Sep 17, 2024
Open
tyxla
tyxla approved these changes Sep 17, 2024
View reviewed changes
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix 👍

BTW it's always useful to link to where this regressed. In this case, it was in #64926.

@tyxla tyxla enabled auto-merge (squash) September 17, 2024 11:32
@tyxla tyxla merged commit afbb659 into trunk Sep 17, 2024
68 checks passed
@tyxla tyxla deleted the fix/vertical-tabs-indicator branch September 17, 2024 11:48
@github-actions github-actions bot added this to the Gutenberg 19.3 milestone Sep 17, 2024
This was referenced Sep 26, 2024
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyxla tyxla tyxla approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@DaniGuardiola DaniGuardiola

Labels
[Package] Components /packages/components [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
Gutenberg 19.3
Development

Successfully merging this pull request may close these issues.
2 participants
@DaniGuardiola @tyxla