Fix: Button Replace remaining 40px default size violations [Edit widgets] #65367
Conversation
dhruvang21
requested review from
draganescu,
adamziel and
kevin940726
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @dhruvang21! In case you missed it, we'd love to have you join us in our Slack community. If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information. |
github-actions
bot
added
the
First-time Contributor
| @@ -44,8 +44,7 @@ export default function InserterSidebar() { | |||
| > | |||
| <TagName className="edit-widgets-layout__inserter-panel-header"> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -51,8 +51,7 @@ export default function ListViewSidebar() { | |||
| <div className="edit-widgets-editor__list-view-panel-header"> | |||
| <strong>{ __( 'List View' ) }</strong> | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
| @@ -66,8 +66,7 @@ export default function WidgetAreas( { selectedWidgetAreaId } ) { | |||
| ) } | |||
| { ! selectedWidgetArea && ( | |||
| <Button | |||
| // TODO: Switch to `true` (40px size) if possible | |||
| __next40pxDefaultSize={ false } | |||
| __next40pxDefaultSize | |||
|
Hi @draganescu, I looked into the issue and found that it’s caused by the overflow: hidden; CSS property in the .edit-widgets-header__navigable-toolbar-wrapper class. I’ve attached a screenshot showing the resolved issue along with a patch for it. Would it be okay to resolve this issue in the current PR, or would you prefer to create a new issue and assign it to me? I’d be happy to create a PR for it. Thanks!
PATCH diff --git a/packages/edit-widgets/src/components/header/style.scss b/packages/edit-widgets/src/components/header/style.scss
.edit-widgets-header__title { |
| variant="secondary" | ||
| ref={ ref } | ||
| > | ||
| <Button __next40pxDefaultSize variant="secondary" ref={ ref }> |
draganescu
added
[Type] Bug
|
@dhruvang21 let's fix the focus cutoff in another issue/PR. Great work here 👏🏻 thank you! |
Part of - #65018
What?
Issue - #65018, To use default to 40px for the button.
Why?
To make the consistent button across Gutenberg, and we would have a lint rule added once fixed, all the button usage.
How?
Change from __next40pxDefaultSize={ false } to __next40pxDefaultSize on component.
Testing Instructions
Screenshot is added for individual changed files.