Revert "Block Insertion: Clear the insertion point when selecting a d… #65208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -41 B (0%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
Mamaduka
approved these changes
Sep 10, 2024
|
Flaky tests detected in e1455ab. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10794373299
|
Mamaduka
reviewed
Sep 10, 2024
Comment on lines
-1627
to
-1628
| case 'CLEAR_SELECTED_BLOCK': | ||
| case 'SELECT_BLOCK': |
There was a problem hiding this comment.
Side note: Based on my git bisect results, this change from #64048 might have been a cause for #65106 (comment).
Mamaduka
added
the
[Feature] Inserter
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This was referenced Sep 26, 2024
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ifferent block or clearing block selection (#64048)"
What?
This reverts commit c73aa36.
Why?
The inserter was relying on getBlockInsertionPoint(), which will update depending on what block is #64048, which causes the inserter sidebar to rerender rapidly.
How?
Reverts back to using getInsertionPoint. A follow-up tor reimplement the fix from #64048 is in progress at #65098
Testing Instructions
For hovering item sidebar rerenders
For pattern rerenders
Testing Instructions for Keyboard
Screenshots or screencast