Spacing control: Replace sides dropdwon with link button #65193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
madhusudhand
added
[Type] Enhancement
|
Size Change: -11.1 kB (-0.62%) Total Size: 1.77 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 981583a. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10791432670
|
vcanales
reviewed
Sep 11, 2024
packages/block-editor/src/components/spacing-sizes-control/linked-button.js
Show resolved
Hide resolved
richtabor
reviewed
Sep 11, 2024
packages/block-editor/src/components/spacing-sizes-control/linked-button.js
Outdated
Show resolved
Hide resolved
richtabor
reviewed
Sep 11, 2024
mikachan
approved these changes
Sep 12, 2024
|
This PR appears to have made the block spacing UI unavailable if the theme defines a default gap for blocks. For example, the TT4 theme defines a default block gap for the Buttons block. If you access the global styles for the Buttons block, you’ll see something like this:
Before this PR was merged, it looked like this:
However, this is not ideal, and since the Buttons block supports the axial gap, it should look like this:
This issue has also been reported here: #64971 (review) My guess is that it has to do with updating the |
|
@t-hamano Your are right. It is because the function In #65371 the function is restored to its original code and included additional condition and it should now be fixed. |
This was referenced Sep 26, 2024
This was referenced Sep 28, 2024
|
I stumbled upon this PR after spotting an incorrect translation submitted via GlotPress for my main locale (pt_PT). The way that strings are built in this PR (as well as preceding strings that the PR is built atop) lends itself to translation mistakes for a few reasons. The term link is almost always used in the hypertextual sense, so translators will struggle to understand We also need syntagmatic information to understand the "link" lexeme: is it a noun? a verb? infinitive or imperative? Few languages are as weakly inflected as English, and using Furthermore, as always, stringing together strings with variables works in English but lends itself to fragile translations in many languages. I'm referring to the fact that we call
The above may or may not apply to this PR, I'll leave that up to you, since it depends on how generic and reusable you want some of the components to be. Finally, but most importantly: is "Link padding" even the right string for the UI in question? That's not how I would describe that button's effect. It's more along the lines of "Link sides", "Link directions", "Link properties", etc. Actually, maybe not so much "link" as "group". My point here is that I suspect that we can come up with a better label that conveniently also does not depend on the property being manipulated. @madhusudhand @mikachan let me know if you need my help. |
|
@mcsf Thanks for the feedback.
I agree with you.
I prefer a hard-coded label of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This changes removes sides dropdown from the
SpacingSizesControl(Padding and Margin), and replaces it with a link button.Fixed #63963 (partially)
Note: no updates to icons in this iteration.
Testing Instructions
horizontal & verticalview andall sidescustom view.Testing Instructions for Keyboard
Screenshots or screencast