Editor topbar: reorder the actions on the right #65163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talldan
added
[Type] Enhancement
talldan
requested review from
noisysocks,
jasmussen,
ramonjd,
kevin940726 and
andrewserong
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +93 B (+0.01%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
talldan
commented
Sep 9, 2024
| @@ -74,11 +74,11 @@ function Editor( { | |||
| <EditorInterface { ...props }> | |||
| { extraContent } | |||
| </EditorInterface> | |||
| { children } | |||
There was a problem hiding this comment.
<Sidebar> is the settings sidebar, which renders the settings toggle in the topbar.
The global styles toggle is rendered through the children, so moving the children to render first should reorder the items.
My main concern though is that it might still allow plugins to render toggles before/after the items inconsistently. I need to do some more testing around that.
talldan
changed the title
|
Flaky tests detected in 6bb0ea0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10777367704
|
|
Very nice. |
|
This looks like a good first step. We can see if order of plugins is a major concern in which we probably should move out the sidebar panel toggle. |
mtias
approved these changes
Sep 9, 2024
|
Nice one! |
2 tasks
2 tasks
This was referenced Sep 26, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Addresses part of #64339
Moves the Save/Publish buttons to the right of the Settings and Global Styles (pinned items) buttons.
Also reorders the Global Styles and Settings buttons, though I'm not sure how reliable this is when plugins register items (see the comment), so I'm still experimenting and looking for feedback on that change.
Why?
As mentioned in the issue, the way the buttons change order can be confusing for users
How?
Swap some lines of code around
Testing Instructions
Test the Post, Site, or Widget editors
Screenshots or screencast
Before
After