Post publish upload media dialog: handle more block types #65122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgomes
added
[Type] Enhancement
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
2 tasks
|
Size Change: +1.18 kB (+0.07%) Total Size: 1.78 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 874c5f5. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/10774199552
|
swissspidy
reviewed
Sep 6, 2024
packages/editor/src/components/post-publish-panel/media-util.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-publish-panel/media-util.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-publish-panel/media-util.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-publish-panel/media-util.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-publish-panel/media-util.js
Outdated
Show resolved
Hide resolved
packages/editor/src/components/post-publish-panel/media-util.js
Outdated
Show resolved
Hide resolved
|
Thank you for the review, @swissspidy! 🙌 I believe I addressed all your comments, so please go ahead and take another look when you get a chance 👍 |
mtias
added
the
[Feature] Media
mtias
reviewed
Sep 7, 2024
I think I'd expect only two images in the list ( |
swissspidy
reviewed
Sep 9, 2024
packages/editor/src/components/post-publish-panel/maybe-upload-media.js
Outdated
Show resolved
Hide resolved
Yes, I agree that would be the most user-friendly approach, in general. That said, I think changes to the UI go somewhat beyond the scope of this PR. Furthermore, I'm not sure if there would be any a11y concerns, since each image can have its own alt text (the demo HTML I provided does this, to verify everything is plumbed correctly), which means it could be important to display them separately. |
swissspidy
approved these changes
Sep 10, 2024
|
Thank you for the review, @swissspidy! 🙌 |
sgomes
deleted the
update/upload-media-dialog-handle-more-block-types
branch
2 tasks
This was referenced Sep 26, 2024
This was referenced Sep 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds new block types to the post publish upload media dialog, so that external images in them are also considered for upload.
As part of this work, it also deduplicates URLs and generates unique filenames before upload.
This PR fixes #64899.
Why?
The post publish upload media dialog suggests uploading external media to the media library, for both performance and reliability reasons. However, it currently only does so for Image blocks, which limits its usefulness.
How?
Custom logic was added to handle
media-textandcoverblocks, as well as to generate adequate filenames before uploading.Testing Instructions
Post contents
/wp-content/uploads/)WordPress-logotype-standard.pngandWordPress-logotype-standard-<some UUID>.png. The second file is expected because we used a different URL (via a query parameter) on the last block, and it's expected to have the UUID for deduplication of the filename.Testing Instructions for Keyboard
N/A, no UI changes.