Skip to content

Writing flow: fix select all with full formatting #64934

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ellatrix merged 2 commits into from
Feb 12, 2026
Merged

Writing flow: fix select all with full formatting #64934

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
895ee33
Writing flow: fix select all with full formatting
ellatrix Aug 30, 2024
190e62c
Add e2e test
ellatrix Aug 30, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions packages/dom/src/dom/is-entirely-selected.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,18 @@ function isDeepChild( query, container, propName ) {
return true;
}
candidate = candidate[ propName ];
// There may be empty text nodes between the first/last child, so ignore
// them.
while (
candidate &&
candidate.nodeType === candidate.TEXT_NODE &&
candidate.nodeValue === ''
) {
candidate =
candidate[
propName === 'lastChild' ? 'previousSibling' : 'nextSibling'
];
}
} while ( candidate );
return false;
}
25 changes: 25 additions & 0 deletions test/e2e/specs/editor/various/multi-block-selection.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1372,6 +1372,31 @@ test.describe( 'Multi-block selection (@firefox, @webkit)', () => {
.poll( multiBlockSelectionUtils.getSelectedFlatIndices )
.toEqual( [ 1, 2 ] );
} );

test( 'should select all with formatting', async ( {
pageUtils,
editor,
multiBlockSelectionUtils,
} ) => {
await editor.insertBlock( {
name: 'core/paragraph',
attributes: { content: '<strong>a</strong>' },
} );
await editor.insertBlock( {
name: 'core/paragraph',
attributes: { content: '<strong>b</strong>' },
} );

await pageUtils.pressKeys( 'primary+a' );
await pageUtils.pressKeys( 'primary+a' );

await expect
.poll( multiBlockSelectionUtils.getSelectedBlocks )
.toMatchObject( [
{ name: 'core/paragraph' },
{ name: 'core/paragraph' },
] );
} );
} );

class MultiBlockSelectionUtils {
Expand Down
Loading